Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use account_threepid_delegate for sending SMS #5929

Closed
dbkr opened this issue Aug 28, 2019 · 2 comments

Comments

@dbkr
Copy link
Member

commented Aug 28, 2019

Do equivalent to what we've done for email, ie. use the account_threepid_delegate to send sms and don't require the client to send an id_server param to /msisdn/requestToken. Hopefully the m.require_identity_server flag can be re-used to signal to the client that an id_server is not required for msisdn token request (apart from for binding, as with email).

Unsure how much of this is already done.

@anoadragon453

This comment has been minimized.

Copy link
Member

commented Aug 30, 2019

I think this issue is a bit out of date and has some misinformation in it.

The current state is that we have an account_threepid_delegates dict with email and msisdn keys. If msisdn is set to a domain name, msisdn-related requests are sent via that domain. If it's empty, all msisdn- related tasks return an error stating that the homeserver does not support this.

@anoadragon453

This comment has been minimized.

Copy link
Member

commented Sep 5, 2019

Closing this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.