Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove email from registration flows if it’s unsupported #6100

Closed
jryans opened this issue Sep 24, 2019 · 1 comment

Comments

@jryans
Copy link
Member

commented Sep 24, 2019

If the HS is not configured to support email (email config block missing and not delegated to an IS), then it should remove email from the registration flows so that clients know they shouldn't show the email field.

@neilisfragile neilisfragile added this to Holding Pen in Homeserver Task Board via automation Sep 24, 2019
@neilisfragile neilisfragile moved this from Holding Pen to To Do in Homeserver Task Board Sep 24, 2019
richvdh added a commit that referenced this issue Sep 25, 2019
If email or msisdn verification aren't supported, let's stop advertising them
for registration.

Fixes #6100.
richvdh added a commit that referenced this issue Sep 25, 2019
Pull the checkers out to their own classes, rather than having them lost in a
massive 1000-line class which does everything.

This is also preparation for some more intelligent advertising of flows, as per #6100
richvdh added a commit that referenced this issue Sep 25, 2019
If email or msisdn verification aren't supported, let's stop advertising them
for registration.

Fixes #6100.
richvdh added a commit that referenced this issue Sep 25, 2019
If email or msisdn verification aren't supported, let's stop advertising them
for registration.

Fixes #6100.
@jryans

This comment has been minimized.

Copy link
Member Author

commented Sep 25, 2019

Fixed by #6107

@jryans jryans closed this Sep 25, 2019
Homeserver Task Board automation moved this from To Do to Done Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.