Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

Fix setting mau_limit_reserved_threepids config #6793

Merged
merged 2 commits into from Jan 28, 2020

Conversation

erikjohnston
Copy link
Member

@erikjohnston erikjohnston commented Jan 28, 2020

Calling the invalidation function during initialisation of the data
stores introduces a circular dependency, causing Synapse to fail to
start.

Fixes #6791

Calling the invalidation function during initialisation of the data
stores introduces a circular dependency, causing Synapse to fail to
start.
@erikjohnston erikjohnston requested a review from a team January 28, 2020 12:17
@erikjohnston erikjohnston changed the base branch from master to release-v1.9.0 January 28, 2020 12:18
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

urghhhhh

@jaywink
Copy link
Member

jaywink commented Jan 28, 2020

Confirmed fix for a live host.

@erikjohnston erikjohnston changed the base branch from release-v1.9.0 to release-v1.9.1 January 28, 2020 13:05
@erikjohnston erikjohnston merged commit bdbeeb9 into release-v1.9.1 Jan 28, 2020
@zymptomLabs
Copy link

zymptomLabs commented Jan 30, 2020

This release broke my home server. I'm using the rest_auth_provider.py library located here https://raw.githubusercontent.com/kamax-matrix/matrix-synapse-rest-auth/master/rest_auth_provider.py

@erikjohnston erikjohnston deleted the erikj/fix_cyclic_dependency branch February 5, 2020 17:35
babolivier pushed a commit that referenced this pull request Sep 1, 2021
* commit 'bdbeeb94e':
  Fix setting `mau_limit_reserved_threepids` config (#6793)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants