/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Remove sent_transactions table. #1188

Merged
merged 3 commits into from Nov 1, 2016

Conversation

Reviewers

@NegativeMjark NegativeMjark

Assignees

@NegativeMjark NegativeMjark

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@erikjohnston @NegativeMjark
@erikjohnston
Owner

erikjohnston commented Oct 31, 2016

It does nothing.
@erikjohnston
Increase batching of sent transaction inserts 
This should further reduce the number of individual inserts,
transactions and updates that are required for keeping sent_transactions
up to date.
4c3eb14

@erikjohnston erikjohnston assigned NegativeMjark Oct 31, 2016

@erikjohnston
Removed unused stuff

All checks have passed

10 successful checks
@matrixbot
Flake8 + Packaging (Commit) — Build #1997 origin/erikj/sent_transactions succeeded in 51 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Dendron (Commit) — Build #1066 origin/erikj/sent_transactions succeeded in 13 min
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #1905 origin/erikj/sent_transactions succeeded in 9 min 25 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #1949 origin/erikj/sent_transactions succeeded in 8 min 22 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #2029 origin/erikj/sent_transactions succeeded in 2 min 17 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
f09d2b6
@NegativeMjark
Contributor

NegativeMjark commented Nov 1, 2016

Sure. LGTM
synapse/storage/transactions.py
- six_hours_ago = now - 6 * 60 * 60 * 1000
-
- def _cleanup_transactions_txn(txn):
- txn.execute("DELETE FROM received_transactions WHERE ts < ?", (month_ago,))
@NegativeMjark

NegativeMjark Nov 1, 2016

Contributor

Are you sure about the received_transactions?

@NegativeMjark
Contributor

NegativeMjark commented Nov 1, 2016 • edited

I think received_transactions is a write-only table as well. Should we stop writing to it as well while we are at it?
@erikjohnston
Continue to clean up received_transactions

Some checks were not successful

1 errored and 9 successful checks
@matrixbot
Sytest Dendron (Commit) — Build #1069 origin/erikj/sent_transactions failed in 2 min 2 sec
Details
@matrixbot
Flake8 + Packaging (Commit) — Build #2000 origin/erikj/sent_transactions succeeded in 1 min 7 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #1908 origin/erikj/sent_transactions succeeded in 9 min 27 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #1952 origin/erikj/sent_transactions succeeded in 6 min 58 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #2032 origin/erikj/sent_transactions succeeded in 3 min 36 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
760469c
@erikjohnston
Owner

erikjohnston commented Nov 1, 2016

I think received_transactions is a write-only table as well. Should we stop writing to it as well while we are at it?

It's used to short circuit duplicate transactions

@erikjohnston erikjohnston merged commit 2746e80 into develop Nov 1, 2016
9 of 10 checks passed

9 of 10 checks passed

Sytest Dendron (Commit) Build #1069 origin/erikj/sent_transactions failed in 2 min 2 sec
Details
Flake8 + Packaging (Commit) Build #2000 origin/erikj/sent_transactions succeeded in 1 min 7 sec
Details
Flake8 + Packaging (Merged PR) Build finished.
Details
Sytest Dendron (Merged PR) Build finished.
Details
Sytest Postgres (Commit) Build #1908 origin/erikj/sent_transactions succeeded in 9 min 27 sec
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Commit) Build #1952 origin/erikj/sent_transactions succeeded in 6 min 58 sec
Details
Sytest SQLite (Merged PR) Build finished.
Details
Unit Tests (Commit) Build #2032 origin/erikj/sent_transactions succeeded in 3 min 36 sec
Details
Unit Tests (Merged PR) Build finished.
Details

@richvdh richvdh deleted the erikj/sent_transactions branch Dec 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment