/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Don't error on non-ascii passwords #1191

Merged
merged 1 commit into from Nov 3, 2016

Conversation

Reviewers
No reviews
Assignees

@NegativeMjark NegativeMjark

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@dbkr @NegativeMjark @erikjohnston
@dbkr
Member

dbkr commented Nov 3, 2016 • edited

Fixes https://matrix.org/jira/browse/SYN-773
Fixes vector-im/vector-web#2538
@dbkr
Don't error on non-ascii passwords

Some checks were not successful

1 errored, 2 failing, and 7 successful checks
@matrixbot
Sytest Dendron (Commit) — Build #1077 origin/dbkr/non_ascii_passwords failed in 12 min
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Flake8 + Packaging (Commit) — Build #2009 origin/dbkr/non_ascii_passwords succeeded in 52 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #1916 origin/dbkr/non_ascii_passwords succeeded in 8 min 32 sec
Details
@matrixbot
Sytest SQLite (Commit) — Build #1961 origin/dbkr/non_ascii_passwords succeeded in 5 min 38 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #2041 origin/dbkr/non_ascii_passwords succeeded in 3 min 15 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
9084720

@dbkr dbkr assigned erikjohnston Nov 3, 2016

@erikjohnston erikjohnston assigned NegativeMjark and unassigned erikjohnston Nov 3, 2016

@NegativeMjark
Contributor

NegativeMjark commented Nov 3, 2016

LGTM

@dbkr dbkr referenced this pull request in matrix-org/sytest Nov 3, 2016

Merged

Test we can register with a non-ascii password #320

@dbkr dbkr merged commit 9164bfa into develop Nov 3, 2016
7 of 10 checks passed

7 of 10 checks passed

Sytest Dendron (Commit) Build #1077 origin/dbkr/non_ascii_passwords failed in 12 min
Details
Sytest Dendron (Merged PR) Build finished.
Details
Sytest Postgres (Merged PR) Build finished.
Details
Flake8 + Packaging (Commit) Build #2009 origin/dbkr/non_ascii_passwords succeeded in 52 sec
Details
Flake8 + Packaging (Merged PR) Build finished.
Details
Sytest Postgres (Commit) Build #1916 origin/dbkr/non_ascii_passwords succeeded in 8 min 32 sec
Details
Sytest SQLite (Commit) Build #1961 origin/dbkr/non_ascii_passwords succeeded in 5 min 38 sec
Details
Sytest SQLite (Merged PR) Build finished.
Details
Unit Tests (Commit) Build #2041 origin/dbkr/non_ascii_passwords succeeded in 3 min 15 sec
Details
Unit Tests (Merged PR) Build finished.
Details

@richvdh richvdh deleted the dbkr/non_ascii_passwords branch Dec 1, 2016

@ara4n ara4n referenced this pull request Dec 18, 2016

Merged

fix ability to change password to a non-ascii one #1711

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment