/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Replace postgres GIN with GIST #1192

Merged
merged 2 commits into from Nov 3, 2016

Conversation

Reviewers

@NegativeMjark NegativeMjark

Assignees

@NegativeMjark NegativeMjark

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@erikjohnston @NegativeMjark
@erikjohnston
Owner

erikjohnston commented Nov 3, 2016 • edited by NegativeMjark

This is because GIN can be slow to write to, especially when the table
gets large.
@erikjohnston
Replace postgres GIN with GIST 
This is because GIN can be slow to write too, especially when the table
gets large.

Some checks were not successful

1 failing and 7 successful checks
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Flake8 + Packaging (Commit) — Build #2011 origin/erikj/postgres_gist succeeded in 49 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Dendron (Commit) — Build #1079 origin/erikj/postgres_gist succeeded in 11 min
Details
@matrixbot
Sytest Postgres (Commit) — Build #1918 origin/erikj/postgres_gist succeeded in 8 min 14 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
8fd4d91

@erikjohnston erikjohnston assigned NegativeMjark Nov 3, 2016

synapse/storage/search.py
+ c = conn.cursor()
+
+ # We create with NULLS FIRST so that when we search *backwards*
+ # we get the ones with non null origin_server_ts *first*
@NegativeMjark

NegativeMjark Nov 3, 2016

Contributor

Is this comment accurate?

@NegativeMjark
Contributor

NegativeMjark commented Nov 3, 2016

Other than the possibly spurious comment, LGTM.
@erikjohnston
Remove spurious comment

Some checks were not successful

1 errored, 1 failing, and 8 successful checks
@matrixbot
Sytest Dendron (Commit) — Build #1080 origin/erikj/postgres_gist failed in 5 min 2 sec
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Flake8 + Packaging (Commit) — Build #2012 origin/erikj/postgres_gist succeeded in 1 min 14 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #1919 origin/erikj/postgres_gist succeeded in 6 min 59 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #1963 origin/erikj/postgres_gist succeeded in 6 min 2 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #2043 origin/erikj/postgres_gist succeeded in 2 min 53 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
64c6566
@NegativeMjark
Contributor

NegativeMjark commented Nov 3, 2016

LGTM

@erikjohnston erikjohnston merged commit 06cc0bb into develop Nov 3, 2016
5 of 10 checks passed

5 of 10 checks passed

Sytest Dendron (Commit) Build #1080 origin/erikj/postgres_gist in progress...
Details
Sytest Dendron (Merged PR) Build started sha1 is merged.
Details
Sytest Postgres (Commit) Build #1919 origin/erikj/postgres_gist in progress...
Details
Sytest Postgres (Merged PR) Build started sha1 is merged.
Details
Sytest SQLite (Merged PR) Build started sha1 is merged.
Details
Flake8 + Packaging (Commit) Build #2012 origin/erikj/postgres_gist succeeded in 1 min 14 sec
Details
Flake8 + Packaging (Merged PR) Build finished.
Details
Sytest SQLite (Commit) Build #1963 origin/erikj/postgres_gist succeeded in 6 min 2 sec
Details
Unit Tests (Commit) Build #2043 origin/erikj/postgres_gist succeeded in 2 min 53 sec
Details
Unit Tests (Merged PR) Build finished.
Details

@richvdh richvdh deleted the erikj/postgres_gist branch Dec 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment