/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Limit the number of prev_events of new events #1615

Merged
merged 2 commits into from Nov 8, 2016

Conversation

Reviewers

@NegativeMjark NegativeMjark

Assignees

@NegativeMjark NegativeMjark

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@erikjohnston @NegativeMjark
@erikjohnston
Owner

erikjohnston commented Nov 8, 2016

No description provided.

@erikjohnston
Limit the number of prev_events of new events

All checks have passed

10 successful checks
@matrixbot
Flake8 + Packaging (Commit) — Build #2022 origin/erikj/limit_prev_events succeeded in 48 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Dendron (Commit) — Build #1090 origin/erikj/limit_prev_events succeeded in 12 min
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #1929 origin/erikj/limit_prev_events succeeded in 10 min
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #1973 origin/erikj/limit_prev_events succeeded in 6 min 31 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #2053 origin/erikj/limit_prev_events succeeded in 2 min 46 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
eeda4e6

@erikjohnston erikjohnston assigned NegativeMjark Nov 8, 2016

@erikjohnston
Sample correctly

Some checks were not successful

1 errored, 1 failing, and 8 successful checks
@matrixbot
Sytest Dendron (Commit) — Build #1092 origin/erikj/limit_prev_events failed in 1 min 54 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Flake8 + Packaging (Commit) — Build #2024 origin/erikj/limit_prev_events succeeded in 1 min 10 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #1931 origin/erikj/limit_prev_events succeeded in 7 min 8 sec
Details
@matrixbot
Sytest SQLite (Commit) — Build #1975 origin/erikj/limit_prev_events succeeded in 8 min 17 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #2055 origin/erikj/limit_prev_events succeeded in 3 min 21 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
a463278
synapse/handlers/message.py
+ # We also randomly point to some of the older events, to make
+ # sure that we don't completely ignore the older events.
+ if latest_ret[5:]:
+ sample_size = min(5, len(latest_ret[5:]))
@NegativeMjark

NegativeMjark Nov 8, 2016

Contributor

The sample size is always 5 here, since this code is only hit if len(latest_ret) > 10.

@erikjohnston erikjohnston merged commit 17e0a58 into develop Nov 8, 2016
8 of 10 checks passed

8 of 10 checks passed

Sytest Dendron (Commit) Build #1092 origin/erikj/limit_prev_events failed in 1 min 54 sec
Details
Sytest Postgres (Merged PR) Build finished.
Details
Flake8 + Packaging (Commit) Build #2024 origin/erikj/limit_prev_events succeeded in 1 min 10 sec
Details
Flake8 + Packaging (Merged PR) Build finished.
Details
Sytest Dendron (Merged PR) Build finished.
Details
Sytest Postgres (Commit) Build #1931 origin/erikj/limit_prev_events succeeded in 7 min 8 sec
Details
Sytest SQLite (Commit) Build #1975 origin/erikj/limit_prev_events succeeded in 8 min 17 sec
Details
Sytest SQLite (Merged PR) Build finished.
Details
Unit Tests (Commit) Build #2055 origin/erikj/limit_prev_events succeeded in 3 min 21 sec
Details
Unit Tests (Merged PR) Build finished.
Details

@richvdh richvdh deleted the erikj/limit_prev_events branch Dec 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment