/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fail with a coherent error message if `/sync?filter=` is invalid #1636

Merged
merged 1 commit into from Nov 21, 2016

Conversation

Reviewers
No reviews
Assignees

@erikjohnston erikjohnston

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Kegsay @erikjohnston
@Kegsay
Contributor

Kegsay commented Nov 21, 2016

Also added M_INVALID_PARAM as there didn't seem to be a suitable error code to represent an invalid/malformed/otherwise wrong input parameter.
@Kegsay
Fail with a coherent error message if `/sync?filter=` is invalid

All checks have passed

10 successful checks
@matrixbot
Flake8 + Packaging (Commit) — Build #2061 origin/kegan/filter-error-msg succeeded in 46 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Dendron (Commit) — Build #1128 origin/kegan/filter-error-msg succeeded in 11 min
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #1967 origin/kegan/filter-error-msg succeeded in 9 min 27 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #2012 origin/kegan/filter-error-msg succeeded in 4 min 34 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #2092 origin/kegan/filter-error-msg succeeded in 3 min 6 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
a2a6c1c

@Kegsay Kegsay assigned erikjohnston Nov 21, 2016

@erikjohnston
Owner

erikjohnston commented Nov 21, 2016

LGTM

@Kegsay Kegsay merged commit a28ec23 into develop Nov 21, 2016
10 checks passed

10 checks passed

Flake8 + Packaging (Commit) Build #2061 origin/kegan/filter-error-msg succeeded in 46 sec
Details
Flake8 + Packaging (Merged PR) Build finished.
Details
Sytest Dendron (Commit) Build #1128 origin/kegan/filter-error-msg succeeded in 11 min
Details
Sytest Dendron (Merged PR) Build finished.
Details
Sytest Postgres (Commit) Build #1967 origin/kegan/filter-error-msg succeeded in 9 min 27 sec
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Commit) Build #2012 origin/kegan/filter-error-msg succeeded in 4 min 34 sec
Details
Sytest SQLite (Merged PR) Build finished.
Details
Unit Tests (Commit) Build #2092 origin/kegan/filter-error-msg succeeded in 3 min 6 sec
Details
Unit Tests (Merged PR) Build finished.
Details

@richvdh richvdh deleted the kegan/filter-error-msg branch Dec 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment