From 89cd4660d445c6f36f07be054c31265a7fb099e4 Mon Sep 17 00:00:00 2001 From: David Robertson Date: Tue, 26 Sep 2023 14:50:41 +0100 Subject: [PATCH 1/4] Consider portdb an integration test --- .github/workflows/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 045d3dd257b9..1f2c20a0ec61 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -535,7 +535,7 @@ jobs: portdb: - if: ${{ !failure() && !cancelled() && needs.changes.outputs.linting == 'true' }} # Allow previous steps to be skipped, but not fail + if: ${{ !failure() && !cancelled() && needs.changes.outputs.integration == 'true'}} # Allow previous steps to be skipped, but not fail needs: - linting-done - changes From ece1447f3776afed065aa8dcef9b7c18e6fe510b Mon Sep 17 00:00:00 2001 From: David Robertson Date: Tue, 26 Sep 2023 14:50:56 +0100 Subject: [PATCH 2/4] Skip export data when integration tests are skipped --- .github/workflows/tests.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 1f2c20a0ec61..adf0287c3c0b 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -499,8 +499,8 @@ jobs: /logs/**/*.log* export-data: - if: ${{ !failure() && !cancelled() }} # Allow previous steps to be skipped, but not fail - needs: [linting-done, portdb] + if: ${{ !failure() && !cancelled() && needs.changes.outputs.integration == 'true'}} # Allow previous steps to be skipped, but not fail + needs: [linting-done, portdb, changes] runs-on: ubuntu-latest env: TOP: ${{ github.workspace }} From 9304a9832e26ae352cc4626eca217f9e55cd2f6f Mon Sep 17 00:00:00 2001 From: David Robertson Date: Tue, 26 Sep 2023 14:54:46 +0100 Subject: [PATCH 3/4] Changelog --- changelog.d/16387.misc | 1 + 1 file changed, 1 insertion(+) create mode 100644 changelog.d/16387.misc diff --git a/changelog.d/16387.misc b/changelog.d/16387.misc new file mode 100644 index 000000000000..eae0501d6b5d --- /dev/null +++ b/changelog.d/16387.misc @@ -0,0 +1 @@ +Avoid running CI steps when the files they check have not been changed. \ No newline at end of file From 98e8b3997a7d0c8af84bf71029783f98b390dfa2 Mon Sep 17 00:00:00 2001 From: David Robertson Date: Tue, 26 Sep 2023 15:00:42 +0100 Subject: [PATCH 4/4] Allow skipping export-data --- .github/workflows/tests.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index adf0287c3c0b..96750cb6c8bb 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -702,6 +702,7 @@ jobs: trial-olddeps sytest portdb + export-data complement check-signoff lint-newsfile