/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Implement E2E for guests #1653

Merged
merged 2 commits into from Nov 29, 2016

Conversation

Reviewers
No reviews
Assignees

@NegativeMjark NegativeMjark

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@richvdh @NegativeMjark @erikjohnston
@richvdh
Member

richvdh commented Nov 25, 2016

Expose the endpoints needed to do e2e to to guest users

richvdh added some commits Nov 25, 2016

@richvdh
Give guest users a device_id 
We need to create devices for guests so that they can use e2e, but we don't
have anywhere to store it, so just use a fixed one.
7f02e4d
@richvdh
Allow guest access to endpoints for E2E 
Expose /devices, /keys, and /sendToDevice to guest users, so that they can use
E2E.

All checks have passed

10 successful checks
@matrixbot
Flake8 + Packaging (Commit) — Build #2100 origin/rav/guest_e2e succeeded in 56 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Dendron (Commit) — Build #1165 origin/rav/guest_e2e succeeded in 11 min
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #2002 origin/rav/guest_e2e succeeded in 9 min 41 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #2046 origin/rav/guest_e2e succeeded in 5 min 28 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #2130 origin/rav/guest_e2e succeeded in 3 min 19 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
f62b69e

@richvdh richvdh assigned erikjohnston Nov 25, 2016

@richvdh
Member

richvdh commented Nov 28, 2016

retest this please
@richvdh
Member

richvdh commented Nov 28, 2016

retest this please

@richvdh richvdh assigned NegativeMjark and unassigned erikjohnston Nov 29, 2016

@richvdh
Member

richvdh commented Nov 29, 2016

retest this please
@richvdh
Member

richvdh commented Nov 29, 2016

TODO: update the spec to add these endpoints to the allowed-for-guests list
@NegativeMjark
Contributor

NegativeMjark commented Nov 29, 2016

LGTM
@richvdh
Member

richvdh commented Nov 29, 2016

ta

@richvdh richvdh merged commit 77eca24 into develop Nov 29, 2016
10 checks passed

10 checks passed

Flake8 + Packaging (Commit) Build #2100 origin/rav/guest_e2e succeeded in 56 sec
Details
Flake8 + Packaging (Merged PR) Build finished.
Details
Sytest Dendron (Commit) Build #1165 origin/rav/guest_e2e succeeded in 11 min
Details
Sytest Dendron (Merged PR) Build finished.
Details
Sytest Postgres (Commit) Build #2002 origin/rav/guest_e2e succeeded in 9 min 41 sec
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Commit) Build #2046 origin/rav/guest_e2e succeeded in 5 min 28 sec
Details
Sytest SQLite (Merged PR) Build finished.
Details
Unit Tests (Commit) Build #2130 origin/rav/guest_e2e succeeded in 3 min 19 sec
Details
Unit Tests (Merged PR) Build finished.
Details

@richvdh richvdh deleted the rav/guest_e2e branch Nov 29, 2016

@richvdh richvdh referenced this pull request in vector-im/riot-web Dec 1, 2016

Closed

Support E2E for guests #2155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment