preview_url_resource: Ellipsis must be in unicode string

[kyrias]

Been getting

UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 0: ordinal not in range(128)

errors due to the ellipsis not being marked as a unicode string. Damn you py2.

[matrixbot]

Can one of the admins verify this patch?

[matrixbot]

Can one of the admins verify this patch?

[matrixbot]

Can one of the admins verify this patch?

[matrixbot]

Can one of the admins verify this patch?

[matrixbot]

Can one of the admins verify this patch?

[kyrias]

Err, whops, deleted the wrong branch .-.

[matrixbot]

Can one of the admins verify this patch?

[matrixbot]

Can one of the admins verify this patch?

[matrixbot]

Can one of the admins verify this patch?

[matrixbot]

Can one of the admins verify this patch?

[matrixbot]

Can one of the admins verify this patch?

[kyrias]

(Also, why is it doing it five times?)

[ara4n]

lgtm - thanks :)

[richvdh]

This has broken the unit tests. Please can we not merge PRs without running the tests.

[kyrias]

Huh, which test? Because without it, this case is broken due to py2 handling of Unicode.

[kyrias]

And I just tried running the tests from master, and they succeed without any failures? Can't find any failures related to this or the develop branch after this in develop either.

[kyrias]

s/from master/from develop/

[richvdh]

http://matrix.org/jenkins/job/SynapseUnittestsCommit/2165/testReport/

The problems are probably in the unit tests rather than your fix, but nevertheless they need fixing. I can do so if you don't beat me to it. My snarky comment was aimed at @ara4n ...

[kyrias]

Ah, seems they're also using non unicode strings. Is there a simple way to run those tests from the commandline btw, since it didn't fail from setup.py test?

[richvdh]

tox -e py27 should do it

Or if you already have a virtualenv, trial tests

[richvdh]

(maybe tox doesn't work; it's a bit of a black box to me tbh)

[kyrias]

Yeah, it seems setup.py test runs the same tests as tox -e py27 though when I try running ./jenkins-unittests.sh I just get the help output of the coverage command, argh.

[kyrias]

tox -e py27 seems to run coverage properly, but no actual unit tests?

[kyrias]

Oh, managed to get them run by setting PYTHONPATH manually.