/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Read-receipt fixes #1678

Merged
merged 2 commits into from Dec 8, 2016

Conversation

Reviewers

@erikjohnston erikjohnston

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@richvdh @erikjohnston
@richvdh
Member

richvdh commented Dec 8, 2016

Fix a couple of issues which could cause read-receipts to be handled
incorrectly and not cause a push notification.

richvdh added some commits Dec 8, 2016

@richvdh
Fix result of insert_receipt 
This should fix the absence of notifications when new receipts arrive.
bd07a35
@richvdh
Fix ignored read-receipts 
Don't ignore read-receipts which arrive in the same EDU as a read-receipt for
an old event.

Some checks were not successful

2 errored and 10 successful checks
@matrixbot
Sytest Postgres (Commit) — Build #2057 origin/rav/fix_receipt_notifications failed in 42 sec
Details
@matrixbot
Sytest SQLite (Commit) — Build #2101 origin/rav/fix_receipt_notifications failed in 6 min 22 sec
Details
@matrixbot
Flake8 + Packaging (Commit) — Build #2162 origin/rav/fix_receipt_notifications succeeded in 51 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Dendron (Commit) — Build #1217 origin/rav/fix_receipt_notifications succeeded in 14 min
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #2186 origin/rav/fix_receipt_notifications succeeded in 3 min 24 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
b08f76b

@richvdh richvdh requested a review from erikjohnston Dec 8, 2016

@richvdh richvdh referenced this pull request in vector-im/riot-android Dec 8, 2016

Closed

Notifications not cleared when room is read with custom HS #769

@erikjohnston

erikjohnston approved these changes Dec 8, 2016
View changes

LGTM

@richvdh richvdh merged commit da13b4a into develop Dec 8, 2016
10 of 12 checks passed

10 of 12 checks passed

Sytest Postgres (Commit) Build #2057 origin/rav/fix_receipt_notifications failed in 42 sec
Details
Sytest SQLite (Commit) Build #2101 origin/rav/fix_receipt_notifications failed in 6 min 22 sec
Details
Flake8 + Packaging (Commit) Build #2162 origin/rav/fix_receipt_notifications succeeded in 51 sec
Details
Flake8 + Packaging (Merged PR) Build finished.
Details
Sytest Dendron (Commit) Build #1217 origin/rav/fix_receipt_notifications succeeded in 14 min
Details
Sytest Dendron (Merged PR) Build finished.
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Merged PR) Build finished.
Details
Unit Tests (Commit) Build #2186 origin/rav/fix_receipt_notifications succeeded in 3 min 24 sec
Details
Unit Tests (Merged PR) Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@richvdh richvdh deleted the rav/fix_receipt_notifications branch Mar 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment