Fix rare notifier bug where listeners dont timeout #1683

Merged
merged 3 commits into from Dec 9, 2016

Projects

None yet

2 participants

@erikjohnston
Member

There was a race condition that caused the notifier to 'miss' the
timeout notification, since there were no other checks for the timeout
this caused listeners to get stuck in a loop until something happened.

@erikjohnston erikjohnston Fix rare notifier bug where listeners dont timeout
There was a race condition that caused the notifier to 'miss' the
timeout notification, since there were no other checks for the timeout
this caused listeners to get stuck in a loop until something happened.
be14c24
@erikjohnston erikjohnston requested a review from NegativeMjark Dec 9, 2016
@NegativeMjark

LGTM

@erikjohnston
Member

@matrixbot retest this please

erikjohnston added some commits Dec 9, 2016
@erikjohnston erikjohnston Correctly handle timeout errors
fbaf868
@erikjohnston erikjohnston Fix unit tests
8b34f71
@NegativeMjark

LGTM

@erikjohnston erikjohnston merged commit b541fac into develop Dec 9, 2016

11 of 12 checks passed

Sytest Dendron (Commit) Build #1224 origin/erikj/notifier_sadness failed in 12 min
Details
Flake8 + Packaging (Commit) Build #2169 origin/erikj/notifier_sadness succeeded in 42 sec
Details
Flake8 + Packaging (Merged PR) Build finished.
Details
Sytest Dendron (Merged PR) Build finished.
Details
Sytest Postgres (Commit) Build #2065 origin/erikj/notifier_sadness succeeded in 8 min 32 sec
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Commit) Build #2108 origin/erikj/notifier_sadness succeeded in 8 min 6 sec
Details
Sytest SQLite (Merged PR) Build finished.
Details
Unit Tests (Commit) Build #2193 origin/erikj/notifier_sadness succeeded in 3 min 5 sec
Details
Unit Tests (Merged PR) Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment