Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Fix rare notifier bug where listeners dont timeout #1683
Conversation
Some checks were not successful
Flake8 + Packaging (Commit)
— Build #2166 origin/erikj/notifier_sadness succeeded in 1 min 19 sec
erikjohnston
requested a review
from NegativeMjark
Dec 9, 2016
erikjohnston
assigned
NegativeMjark
Dec 9, 2016
|
@matrixbot retest this please |
erikjohnston
added some commits
Dec 9, 2016
Some checks were not successful
Sytest Postgres (Commit)
— Build #2064 origin/erikj/notifier_sadness succeeded in 8 min 14 sec
Some checks were not successful
Sytest Postgres (Commit)
— Build #2065 origin/erikj/notifier_sadness succeeded in 8 min 32 sec
erikjohnston
merged commit b541fac
into
develop
Dec 9, 2016
11 of 12 checks passed
Sytest Dendron (Commit)
Build #1224 origin/erikj/notifier_sadness failed in 12 min
Details
Flake8 + Packaging (Commit)
Build #2169 origin/erikj/notifier_sadness succeeded in 42 sec
Details
Flake8 + Packaging (Merged PR)
Build finished.
Details
Sytest Dendron (Merged PR)
Build finished.
Details
Sytest Postgres (Commit)
Build #2065 origin/erikj/notifier_sadness succeeded in 8 min 32 sec
Details
Sytest Postgres (Merged PR)
Build finished.
Details
Sytest SQLite (Commit)
Build #2108 origin/erikj/notifier_sadness succeeded in 8 min 6 sec
Details
Sytest SQLite (Merged PR)
Build finished.
Details
Unit Tests (Commit)
Build #2193 origin/erikj/notifier_sadness succeeded in 3 min 5 sec
Details
Unit Tests (Merged PR)
Build finished.
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
continuous-integration/travis-ci/push
The Travis CI build passed
Details
erikjohnston
deleted the
erikj/notifier_sadness
branch
Mar 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
erikjohnston commentedDec 9, 2016
There was a race condition that caused the notifier to 'miss' the
timeout notification, since there were no other checks for the timeout
this caused listeners to get stuck in a loop until something happened.