/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

E2E key query: handle federation fails #1686

Merged
merged 2 commits into from Dec 12, 2016

Conversation

Reviewers

@NegativeMjark NegativeMjark

Assignees

@NegativeMjark NegativeMjark

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@richvdh @NegativeMjark
@richvdh
Member

richvdh commented Dec 9, 2016

Don't fail the whole request if we can't connect to a particular server.

(Should we have a helper somewhere to do this wrapping for us?)
@richvdh
E2E key query: handle federation fails 
Don't fail the whole request if we can't connect to a particular server.

Some checks were not successful

2 errored, 3 failing, and 7 successful checks
@matrixbot
Flake8 + Packaging (Commit) — Build #2175 origin/rav/fix_federation_key_fails failed in 44 sec
Details
@matrixbot
Sytest Dendron (Commit) — Build #1229 origin/rav/fix_federation_key_fails failed in 3 min 49 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
continuous-integration/travis-ci/pr — The Travis CI build failed
Details
continuous-integration/travis-ci/push — The Travis CI build failed
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #2071 origin/rav/fix_federation_key_fails succeeded in 8 min 37 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #2114 origin/rav/fix_federation_key_fails succeeded in 7 min 59 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #2199 origin/rav/fix_federation_key_fails succeeded in 2 min 59 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
efa4ccf

@richvdh richvdh assigned NegativeMjark Dec 9, 2016

@NegativeMjark

NegativeMjark approved these changes Dec 9, 2016
View changes

LGTM?

@richvdh
Remove unused import

Some checks were not successful

2 failing and 9 successful checks
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Dendron (Commit) — Build #1231 origin/rav/fix_federation_key_fails succeeded in 14 min
Details
@matrixbot
Sytest Postgres (Commit) — Build #2073 origin/rav/fix_federation_key_fails succeeded in 9 min 22 sec
Details
@matrixbot
Sytest SQLite (Commit) — Build #2116 origin/rav/fix_federation_key_fails succeeded in 6 min 8 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #2201 origin/rav/fix_federation_key_fails succeeded in 3 min 16 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
deca951

@richvdh richvdh merged commit 85cd30b into develop Dec 12, 2016
6 of 11 checks passed

6 of 11 checks passed

Sytest Dendron (Merged PR) Build finished.
Details
Sytest Dendron (Commit) Build #1231 origin/rav/fix_federation_key_fails in progress...
Details
Sytest Postgres (Commit) Build #2073 origin/rav/fix_federation_key_fails in progress...
Details
Sytest Postgres (Merged PR) Build started sha1 is merged.
Details
Sytest SQLite (Commit) Build #2116 origin/rav/fix_federation_key_fails in progress...
Details
Flake8 + Packaging (Merged PR) Build finished.
Details
Sytest SQLite (Merged PR) Build finished.
Details
Unit Tests (Commit) Build #2201 origin/rav/fix_federation_key_fails succeeded in 3 min 16 sec
Details
Unit Tests (Merged PR) Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@richvdh richvdh deleted the rav/fix_federation_key_fails branch Mar 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment