Remove unspecced GET endpoints for e2e keys #1694

Merged
merged 1 commit into from Dec 12, 2016

Projects

None yet

2 participants

@richvdh
Member
richvdh commented Dec 12, 2016

GET /keys/claim is a terrible idea, since it isn't idempotent; also it throws
500 errors if you call it without all the right params.

GET /keys/query is arguable, but it's unspecced, so let's get rid of it too to
stop people relying on unspecced APIs.

@erikjohnston
Member

I take it these are unused?

@erikjohnston
Member

(I don't see any calls to those APIs on matrix.org over the weekend)

@richvdh richvdh added a commit to matrix-org/sytest that referenced this pull request Dec 12, 2016
@richvdh richvdh Make E2E key tests use specced endpoints
matrix-org/synapse#1694 removes the unspecced
endpoints, so don't try to use them.
79f65e4
@richvdh richvdh referenced this pull request in matrix-org/sytest Dec 12, 2016
Merged

Make E2E key tests use specced endpoints #330

@richvdh
Member
richvdh commented Dec 12, 2016

Yeah... apparently the tests don't think so though. Working on them.

@richvdh
Member
richvdh commented Dec 12, 2016

retest this please

@richvdh richvdh Remove unspecced GET endpoints for e2e keys
GET /keys/claim is a terrible idea, since it isn't idempotent; also it throws
500 errors if you call it without all the right params.

GET /keys/query is arguable, but it's unspecced, so let's get rid of it too to
stop people relying on unspecced APIs.
abed247
@richvdh richvdh requested a review from erikjohnston Dec 12, 2016
@erikjohnston

LGTM, once the sytests have been merged

@richvdh richvdh merged commit d431c09 into develop Dec 12, 2016

5 of 8 checks passed

Sytest Dendron (Merged PR) Build finished.
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Merged PR) Build finished.
Details
Sytest Dendron (Commit) Build #1239 origin/rav/no_get_e2e_keys succeeded in 13 min
Details
Sytest Postgres (Commit) Build #2080 origin/rav/no_get_e2e_keys succeeded in 7 min 52 sec
Details
Sytest SQLite (Commit) Build #2123 origin/rav/no_get_e2e_keys succeeded in 6 min 50 sec
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment