Add support for specifying multiple bind addresses #1709

Merged
merged 4 commits into from Dec 19, 2016

Projects

None yet

4 participants

@kyrias
Contributor
kyrias commented Dec 18, 2016

No description provided.

kyrias added some commits Dec 18, 2016
@kyrias kyrias Add support for specifying multiple bind addresses
Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
7dfd70f
@kyrias kyrias Make default homeserver config use bind_addresses
Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
c95e9ff
@kyrias kyrias Update README to use `bind_addresses`
Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
1859af9
@matrixbot

Can one of the admins verify this patch?

@matrixbot

Can one of the admins verify this patch?

@matrixbot

Can one of the admins verify this patch?

- # The empty string will cause synapse to listen on all interfaces.
- bind_address: ''
+ # Local addresses to listen on.
+ # This will listen on all IPv4 addresses by default.
@ara4n
ara4n Dec 18, 2016 edited Member

Can we have the example in here of how to listen on ipv6 too, even if commented out? presumably

# - '::'  # to listen on all IPv6 interfaces
@kyrias
kyrias Dec 18, 2016 Contributor

I was thinking about that, but also need to specify that having both uncommented at the same time won't work on Linux, so I was thinking about whether to document this in the default config or somewhere else?

@ara4n
ara4n Dec 18, 2016 Member

it's going to be such a common scenario (plus we want to advertise that ipv6 is here, yay!) that i suspect it's worth spelling it out (assuming you are sure that the second bind will fail?)
how about:

 # uncomment to listen on all IPv6 interfaces
 # N.B. on Linux this also listens on IPv4, so you'll need to comment out the line above.
 # - '::'
@kyrias
kyrias Dec 18, 2016 Contributor

On Linux you'll get an errno 98, yeah, annoyingly.

Comment added below.

@ara4n
Member
ara4n commented Dec 18, 2016

this LGTM, modulo the minor doc change. annoying that the binding setup is copypasted over all the different workers though, but not your fault...

@kyrias kyrias was assigned by ara4n Dec 18, 2016
@ara4n ara4n referenced this pull request Dec 18, 2016
Merged

IPv6 support #1696

@kyrias kyrias Add IPv6 comment to default config
Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
f5cd5eb
@richvdh
Member
richvdh commented Dec 19, 2016

ok to test

@ara4n
Member
ara4n commented Dec 19, 2016

lgtm - going to merge and see what happens! thanks @kyrias!

@ara4n ara4n merged commit da2c8f3 into matrix-org:develop Dec 19, 2016

3 of 4 checks passed

Sytest Dendron (Merged PR) Build finished.
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Merged PR) Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kyrias kyrias deleted the kyrias:bind_addresses branch Dec 20, 2016
@kyrias kyrias added a commit to kyrias/synapse that referenced this pull request Jan 8, 2017
@kyrias kyrias Revert "Merge pull request #1709 from kyrias/bind_addresses"
This reverts commit da2c8f3, reversing
changes made to a58e4e0.
fda1c8e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment