Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Add support for specifying multiple bind addresses #1709
Conversation
kyrias
added some commits
Dec 18, 2016
matrixbot
commented
Dec 18, 2016
|
Can one of the admins verify this patch? |
matrixbot
commented
Dec 18, 2016
|
Can one of the admins verify this patch? |
matrixbot
commented
Dec 18, 2016
|
Can one of the admins verify this patch? |
| - # The empty string will cause synapse to listen on all interfaces. | ||
| - bind_address: '' | ||
| + # Local addresses to listen on. | ||
| + # This will listen on all IPv4 addresses by default. |
ara4n
Dec 18, 2016
•
Owner
Can we have the example in here of how to listen on ipv6 too, even if commented out? presumably
# - '::' # to listen on all IPv6 interfaces
kyrias
Dec 18, 2016
Contributor
I was thinking about that, but also need to specify that having both uncommented at the same time won't work on Linux, so I was thinking about whether to document this in the default config or somewhere else?
ara4n
Dec 18, 2016
Owner
it's going to be such a common scenario (plus we want to advertise that ipv6 is here, yay!) that i suspect it's worth spelling it out (assuming you are sure that the second bind will fail?)
how about:
# uncomment to listen on all IPv6 interfaces
# N.B. on Linux this also listens on IPv4, so you'll need to comment out the line above.
# - '::'
kyrias
Dec 18, 2016
Contributor
On Linux you'll get an errno 98, yeah, annoyingly.
Comment added below.
|
this LGTM, modulo the minor doc change. annoying that the binding setup is copypasted over all the different workers though, but not your fault... |
ara4n
assigned
kyrias
Dec 18, 2016
|
ok to test |
|
lgtm - going to merge and see what happens! thanks @kyrias! |
ara4n
merged commit da2c8f3
into
matrix-org:develop
Dec 19, 2016
kyrias
deleted the
kyrias:bind_addresses
branch
Dec 20, 2016
kyrias
added a commit
to kyrias/synapse
that referenced
this pull request
Jan 8, 2017
kyrias commentedDec 18, 2016
No description provided.