/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix check for bind_address #1712

Merged
merged 1 commit into from Dec 20, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@kyrias @matrixbot @ara4n
@kyrias
Contributor

kyrias commented Dec 20, 2016

The empty string is a valid setting for the bind_address option, so
explicitly check for None here instead.

This fixes a regression in 7dfd70f
@kyrias
Fix check for bind_address 
The empty string is a valid setting for the bind_address option, so
explicitly check for None here instead.

Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
702c020
@matrixbot

matrixbot commented Dec 20, 2016

Can one of the admins verify this patch?
@matrixbot

matrixbot commented Dec 20, 2016

Can one of the admins verify this patch?
@matrixbot

matrixbot commented Dec 20, 2016

Can one of the admins verify this patch?
@ara4n
Owner

ara4n commented Dec 20, 2016

oops. lgtm - thanks!

@ara4n ara4n merged commit b7f4f90 into matrix-org:develop Dec 20, 2016
1 check was pending

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@kyrias kyrias deleted the kyrias:fix-bind-address-none branch Dec 20, 2016

@kyrias
Contributor

kyrias commented Dec 20, 2016

(Thanks for the quick merge ❤)

kyrias added a commit to kyrias/synapse that referenced this pull request Jan 8, 2017

@kyrias
Revert "Merge pull request #1712 from kyrias/fix-bind-address-none" 
This reverts commit b7f4f90, reversing
changes made to 09f1591.
456248f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment