Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Add /account/3pid/delete endpoint #1714
Conversation
Some checks were not successful
dbkr
assigned
NegativeMjark
Dec 20, 2016
| @@ -617,6 +617,17 @@ def add_threepid(self, user_id, medium, address, validated_at): | ||
| self.hs.get_clock().time_msec() | ||
| ) | ||
| + @defer.inlineCallbacks |
| @@ -617,6 +617,17 @@ def add_threepid(self, user_id, medium, address, validated_at): | ||
| self.hs.get_clock().time_msec() | ||
| ) | ||
| + @defer.inlineCallbacks | ||
| + def delete_threepid(self, user_id, medium, address): | ||
| + # 'Canonicalise' email addresses as per above |
ara4n
Dec 20, 2016
Owner
you're going to hate me for asking this, but: should we be canonicalising MSISDNs here? or are we assuming the client has already determined normal form? (If so, a comment would be useful)
dbkr
Dec 21, 2016
Member
In this case, the msisdn canonicalisation will have been done by the ID server (or the thing doing the verification). In fact, with us now having decided to have a separate thing to do the actual validation of 3pids, the email canonicalisation would go there too (it's a bit tricky for email given that squelching the localpart down to lowercase is not technically valid).
ara4n
assigned
ara4n
and unassigned
NegativeMjark
Dec 20, 2016
|
lgtm other than 2 comments |
dbkr commentedDec 20, 2016
Also fix a typo in a comment