/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Use the new twisted logging framework. #1731

Merged
merged 1 commit into from Dec 30, 2016

Conversation

Reviewers

@ara4n ara4n

Assignees

@ara4n ara4n

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@NegativeMjark @ara4n
@NegativeMjark
Contributor

NegativeMjark commented Dec 30, 2016

Hopefully adding an observer to the new framework will avoid a memory
leak https://twistedmatrix.com/trac/ticket/8164
@NegativeMjark
Use the new twisted logging framework. 
Hopefully adding an observer to the new framework will avoid a memory
leak https://twistedmatrix.com/trac/ticket/8164

Some checks were not successful

2 failing and 6 successful checks
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Sytest Dendron (Commit) — Build #1283 origin/markjh/logging-memleak succeeded in 12 min
Details
@matrixbot
Sytest Postgres (Commit) — Build #2126 origin/markjh/logging-memleak succeeded in 8 min 53 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #2168 origin/markjh/logging-memleak succeeded in 8 min 1 sec
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
822cb39

@NegativeMjark NegativeMjark assigned ara4n Dec 30, 2016

@NegativeMjark NegativeMjark referenced this pull request Dec 30, 2016

Closed

avoid leaking twisted log events by routing them to python's logging #1728

@ara4n

ara4n reviewed Dec 30, 2016
View changes

lgtm - thanks for fixing the collision with the legacy logging stuff.

@NegativeMjark NegativeMjark merged commit 0eac4fa into release-v0.18.6 Dec 30, 2016
6 of 8 checks passed

6 of 8 checks passed

Sytest Dendron (Merged PR) Build finished.
Details
Sytest SQLite (Merged PR) Build finished.
Details
Sytest Dendron (Commit) Build #1283 origin/markjh/logging-memleak succeeded in 12 min
Details
Sytest Postgres (Commit) Build #2126 origin/markjh/logging-memleak succeeded in 8 min 53 sec
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Commit) Build #2168 origin/markjh/logging-memleak succeeded in 8 min 1 sec
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment