/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Remove fallback from get_missing_events. #1734

Merged
merged 1 commit into from Dec 30, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@NegativeMjark
@NegativeMjark
Contributor

NegativeMjark commented Dec 30, 2016 • edited by ara4n

get_missing_events used to fallback to fetching the missing events
individually requesting from every server in the room, one by one.e

This could be unacceptably slow, possibly causing #1733
@NegativeMjark
Remove fallback from get_missing_events. 
get_missing_events used to fallback to fetching the missing events
individually requesting from every server in the room, one by one.e

This could be unacceptably slow, possibly causing #1732

Some checks were not successful

1 errored, 1 failing, and 6 successful checks
@matrixbot
Sytest Dendron (Commit) — Build #1287 origin/markjh/fix_get_missing failed in 1 min 9 sec
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #2130 origin/markjh/fix_get_missing succeeded in 6 min 51 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #2172 origin/markjh/fix_get_missing succeeded in 5 min 30 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
cc50b1a

@NegativeMjark NegativeMjark merged commit 48c3b7d into release-v0.18.6 Dec 30, 2016
6 of 8 checks passed

6 of 8 checks passed

Sytest Dendron (Commit) Build #1287 origin/markjh/fix_get_missing failed in 1 min 9 sec
Details
Sytest Dendron (Merged PR) Build finished.
Details
Sytest Postgres (Commit) Build #2130 origin/markjh/fix_get_missing succeeded in 6 min 51 sec
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Commit) Build #2172 origin/markjh/fix_get_missing succeeded in 5 min 30 sec
Details
Sytest SQLite (Merged PR) Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ara4n ara4n referenced this pull request Dec 30, 2016

Closed

Servers may sometimes temporarily blackhole federation traffic #1733

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment