Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
limit total timeout for get_missing_events to 10s #1744
Conversation
Some checks were not successful
ara4n
assigned
NegativeMjark
Dec 31, 2016
|
It might be worth noting in the comment that this disables HTTP client retries entirely. Also worth noting in the comment that this increases the chances of falling back to fetching state, which curiously isn't guarded by the same lock as the get_missing_events. Also might be worth mentioning in the comment that we don't want to block for a long time because we are holding a lock on the room that could block other transactions that needed to fetch missing events. Other than lack of comments LGTM. |
|
will fix #1741 when merged |
ara4n
referenced this pull request
Jan 5, 2017
Closed
Servers may sometimes temporarily blackhole federation traffic #1733
Some checks were not successful
|
@NegativeMjark have updated the comment - PTAL |
|
LGTM |
NegativeMjark
merged commit 5175094
into
develop
Jan 5, 2017
2 of 6 checks passed
NegativeMjark
added a commit
that referenced
this pull request
Jan 5, 2017
ara4n commentedDec 31, 2016
•
edited
timeout calls to get_missing_events from the federation client after 10s rather than the current 5 minutes. should improve the workaround for #1733 and #1729 some more.