Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
JSONSchema Validation For Filters #1783
Conversation
matrixbot
commented
Jan 8, 2017
|
Can one of the admins verify this patch? |
matrixbot
commented
Jan 8, 2017
|
Can one of the admins verify this patch? |
matrixbot
commented
Jan 8, 2017
|
Can one of the admins verify this patch? |
| + "timeline": { | ||
| + "$ref": "#/definitions/room_event_filter" | ||
| + }, | ||
| + "accpount_data": { |
|
looks good to me, just requires a rebase |
|
@matrixbot ok to test |
pik
added some commits
Mar 23, 2017
|
Thanks! |
erikjohnston
merged commit 6af0096
into
matrix-org:develop
Mar 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
pik commentedJan 8, 2017
Also the that the
room_event_filterschema supplied by the spec does not actually function in all cases e.g. ##1782 - should probably be addressed, adding test cases and either by adding the missing functionality or limiting the schema.