Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Limit number of entries to prefill from cache #1792
Conversation
erikjohnston
assigned
NegativeMjark
Jan 10, 2017
|
LGTM codewise but I don't think it'll actually fix the perf for device_inbox prefill since the query is doing an index scan rather than a backwards index scan. See query plans #1768. |
It does, I tested it.
Going forwards or backwards only matters if you're counting. When using the |
|
K, makes sense. (would be really awesome if we could tune this on a worker by worker basis, but I digress). |
erikjohnston commentedJan 10, 2017
Some tables, like device_inbox, take a long time to query at startup for
the stream change cache prefills. This is likely because they are slower
growing streams and so are more fragmented on disk. For now, lets pull
fewer entries out to make startup quicker.
In future, we should add a better index to make it even faster.