Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Remove full_twisted_stacktraces option #1802
Conversation
erikjohnston
assigned
NegativeMjark
Jan 12, 2017
erikjohnston
referenced this pull request
Jan 12, 2017
Closed
@kyrias's HS on develop is leaking inbound FDs and filling up with CRITICAL endpoint errors #1778
|
LGTM |
erikjohnston
merged commit 7a13fe1
into
develop
Jan 12, 2017
7 of 8 checks passed
Sytest Dendron (Merged PR)
Build finished.
Details
Sytest Dendron (Commit)
Build #1352 origin/erikj/remove_debug_deferreds succeeded in 10 min
Details
Sytest Postgres (Commit)
Build #2170 origin/erikj/remove_debug_deferreds succeeded in 7 min 45 sec
Details
Sytest Postgres (Merged PR)
Build finished.
Details
Sytest SQLite (Commit)
Build #2237 origin/erikj/remove_debug_deferreds succeeded in 5 min 43 sec
Details
Sytest SQLite (Merged PR)
Build finished.
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
continuous-integration/travis-ci/push
The Travis CI build passed
Details
erikjohnston
deleted the
erikj/remove_debug_deferreds
branch
Mar 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
erikjohnston commentedJan 12, 2017
The debug 'full_twisted_stacktraces' flag caused synapse to rewrite
twisted deferreds to always fire the callback on the next reactor tick.
This was to force the deferred to always store the stacktraces on
exceptions, and thus be more likely to have a full stacktrace when it
reaches the final error handlers and gets printed to the logs.
Dynamically rewriting things is generally bad, and in particular this
change violates assumptions of various bits of Twisted. This wouldn't
necessarily be so bad, but it turns out this option has been turned on
on some production servers.
Turning the option can cause e.g. #1778.
For now, lets just entirely nuke this option.