/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix bug where current_state_events renamed to current_state_ids #1849

Merged
merged 1 commit into from Mar 29, 2017

Conversation

Reviewers
No reviews
Assignees

@erikjohnston erikjohnston

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@erikjohnston @NegativeMjark
@erikjohnston
Owner

erikjohnston commented Jan 23, 2017

No description provided.

@erikjohnston
Fix bug where current_state_events renamed to current_state_ids

All checks have passed

8 successful checks
@matrixbot
Sytest Dendron (Commit) — Build #1417 origin/erikj/state_typo succeeded in 10 min
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #2234 origin/erikj/state_typo succeeded in 7 min 13 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #2302 origin/erikj/state_typo succeeded in 5 min 59 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
41dab8a

@erikjohnston erikjohnston assigned NegativeMjark Jan 23, 2017

@erikjohnston
Owner

erikjohnston commented Jan 23, 2017

fixes #1785
@NegativeMjark
Contributor

NegativeMjark commented Jan 23, 2017

This looks like it probably fixes the ISE in #1785. I would appreciate if we had a slightly better idea of what the code is doing here since I think it should only be reached via https://github.com/matrix-org/synapse/blob/v0.18.7-rc2/synapse/federation/federation_server.py#L559
@NegativeMjark
Contributor

NegativeMjark commented Jan 23, 2017

It seems a bit weird to attempt to store an outlier with state since I thought the whole point of an outlier was that it was an event without state. Would it make more sense to treat the event as some weird form of backfill in this case?

@NegativeMjark NegativeMjark assigned erikjohnston and unassigned NegativeMjark Feb 20, 2017

@erikjohnston
Owner

erikjohnston commented Mar 29, 2017

We probably don't persist it, but use it to do some auth on the event.

@erikjohnston erikjohnston merged commit b9c2ae6 into develop Mar 29, 2017
8 checks passed

8 checks passed

Sytest Dendron (Commit) Build #1417 origin/erikj/state_typo succeeded in 10 min
Details
Sytest Dendron (Merged PR) Build finished.
Details
Sytest Postgres (Commit) Build #2234 origin/erikj/state_typo succeeded in 7 min 13 sec
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Commit) Build #2302 origin/erikj/state_typo succeeded in 5 min 59 sec
Details
Sytest SQLite (Merged PR) Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@richvdh richvdh referenced this pull request Oct 5, 2017

Closed

Attribute Error: EventContext has no attribute "current_state_events" #1785

@erikjohnston erikjohnston deleted the erikj/state_typo branch Oct 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment