/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Implement /keys/changes #1869

Merged
merged 3 commits into from Feb 1, 2017

Conversation

Reviewers

@NegativeMjark NegativeMjark

Assignees

@NegativeMjark NegativeMjark

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@erikjohnston @NegativeMjark
@erikjohnston
Owner

erikjohnston commented Feb 1, 2017

No description provided.

erikjohnston added some commits Feb 1, 2017

@erikjohnston
Implement /keys/changes

All checks have passed

2 successful checks
@matrixbot
Sytest Postgres (Commit) — Build #2271 origin/erikj/device_list_stream succeeded in 7 min 21 sec
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
97479d0
@erikjohnston
Comment

Some checks were not successful

1 errored, 1 failing, and 6 successful checks
@matrixbot
Sytest Dendron (Commit) — Build #1454 origin/erikj/device_list_stream failed in 12 min
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #2272 origin/erikj/device_list_stream succeeded in 7 min 23 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #2340 origin/erikj/device_list_stream succeeded in 6 min 12 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
acb501c

@erikjohnston erikjohnston assigned NegativeMjark Feb 1, 2017

synapse/rest/client/v2_alpha/keys.py
@@ -149,6 +151,52 @@ def on_POST(self, request):
defer.returnValue((200, result))
+class KeyChangesServlet(RestServlet):
+ """Returns the list of changes of keys between two stream tokens (may return
+ spurious results).
@NegativeMjark

NegativeMjark Feb 1, 2017

Contributor

Maybe explain why the results might be spurious and the nature of their spuriosity?

@erikjohnston
Comment

Some checks were not successful

1 failing and 6 successful checks
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #2277 origin/erikj/device_list_stream succeeded in 7 min 54 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #2346 origin/erikj/device_list_stream succeeded in 4 min 40 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
73d676d

@erikjohnston erikjohnston merged commit bd84387 into develop Feb 1, 2017
2 of 7 checks passed

2 of 7 checks passed

Sytest Dendron (Merged PR) Build finished.
Details
Sytest Postgres (Commit) Build #2277 origin/erikj/device_list_stream in progress...
Details
Sytest Postgres (Merged PR) Build started sha1 is merged.
Details
Sytest SQLite (Commit) Build #2346 origin/erikj/device_list_stream in progress...
Details
Sytest SQLite (Merged PR) Build started sha1 is merged.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@erikjohnston erikjohnston deleted the erikj/device_list_stream branch Mar 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment