Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Include newly joined users in /keys/changes API #1872
Conversation
Some checks were not successful
erikjohnston
assigned
NegativeMjark
Feb 1, 2017
All checks have passed
erikjohnston
assigned
richvdh
and unassigned
NegativeMjark
Feb 1, 2017
| + def get_rooms_that_changed(self, room_ids, from_key): | ||
| + """Given a list of rooms and a token, return rooms where there may have | ||
| + been changes. | ||
| + """ |
richvdh
Feb 1, 2017
Member
wouldn't hurt to document the type of the params, especially from_key. I always find it impossible to keep track of what type of sync token is what.
richvdh
assigned
erikjohnston
and unassigned
richvdh
Feb 1, 2017
Some checks were not successful
erikjohnston
merged commit 14d5e22
into
develop
Feb 1, 2017
5 of 8 checks passed
Sytest Dendron (Commit)
Build #1466 origin/erikj/key_changes in progress...
Details
Sytest Dendron (Merged PR)
Build started sha1 is merged.
Details
Sytest SQLite (Merged PR)
Build started sha1 is merged.
Details
Sytest Postgres (Commit)
Build #2286 origin/erikj/key_changes succeeded in 7 min 25 sec
Details
Sytest Postgres (Merged PR)
Build finished.
Details
Sytest SQLite (Commit)
Build #2354 origin/erikj/key_changes succeeded in 5 min 59 sec
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
continuous-integration/travis-ci/push
The Travis CI build passed
Details
erikjohnston
deleted the
erikj/key_changes
branch
Mar 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
erikjohnston commentedFeb 1, 2017
No description provided.