Include newly joined users in /keys/changes API #1872

Merged
merged 3 commits into from Feb 1, 2017

Projects

None yet

3 participants

@erikjohnston
Member

No description provided.

@erikjohnston erikjohnston Include newly joined users in /keys/changes API
7e919bd
@erikjohnston erikjohnston Comment
d61a045
@erikjohnston erikjohnston assigned richvdh and unassigned NegativeMjark Feb 1, 2017
@richvdh
richvdh approved these changes Feb 1, 2017 View changes

LGTM otherwise? It's definitely python.

synapse/storage/stream.py
+ def get_rooms_that_changed(self, room_ids, from_key):
+ """Given a list of rooms and a token, return rooms where there may have
+ been changes.
+ """
@richvdh
richvdh Feb 1, 2017 Member

wouldn't hurt to document the type of the params, especially from_key. I always find it impossible to keep track of what type of sync token is what.

@richvdh richvdh assigned erikjohnston and unassigned richvdh Feb 1, 2017
@erikjohnston erikjohnston Doc args
fbfe44b
@erikjohnston erikjohnston merged commit 14d5e22 into develop Feb 1, 2017

5 of 8 checks passed

Sytest Dendron (Commit) Build #1466 origin/erikj/key_changes in progress...
Details
Sytest Dendron (Merged PR) Build started sha1 is merged.
Details
Sytest SQLite (Merged PR) Build started sha1 is merged.
Details
Sytest Postgres (Commit) Build #2286 origin/erikj/key_changes succeeded in 7 min 25 sec
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Commit) Build #2354 origin/erikj/key_changes succeeded in 5 min 59 sec
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment