/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Use signedjson.sign instead of syutil.crypto.jsonsign #1907

Merged
merged 1 commit into from Feb 13, 2017

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@andrewshadura @matrixbot @erikjohnston
@andrewshadura
Contributor

andrewshadura commented Feb 12, 2017

Functions from syutil.crypto.jsonsign are now available in
signedjson, so use that instead of depending on syutil.
@matrixbot

matrixbot commented Feb 12, 2017

Can one of the admins verify this patch?
@matrixbot

matrixbot commented Feb 12, 2017

Can one of the admins verify this patch?
@matrixbot

matrixbot commented Feb 12, 2017

Can one of the admins verify this patch?
@erikjohnston
Owner

erikjohnston commented Feb 13, 2017

@matrixbot ok to test
@erikjohnston
Owner

erikjohnston commented Feb 13, 2017

Err, the dendron test looks like it failed to start. Otherwise, looks good to me! Thanks!
@erikjohnston
Owner

erikjohnston commented Feb 13, 2017

Oh, could you sign this off please as per https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.rst#sign-off?
@andrewshadura
Use signedjson.sign instead of syutil.crypto.jsonsign 
Functions from syutil.crypto.jsonsign are now available in
signedjson, so use that instead of depending on syutil.

Signed-off-by: Andrew Shadura <andrew@shadura.me>
This commit was signed with a verified signature.
@andrewshadura andrewshadura Andrew Shadura
GPG key ID: 9D5B23F9184FA514 Learn about signing commits

Some checks were not successful

1 failing and 3 successful checks
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
6a3743b
@andrewshadura
Contributor

andrewshadura commented Feb 13, 2017

@erikjohnston, done.
@erikjohnston
Owner

erikjohnston commented Feb 13, 2017

Thanks!

@erikjohnston erikjohnston merged commit e1a12e2 into matrix-org:develop Feb 13, 2017
3 of 4 checks passed

3 of 4 checks passed

Sytest Dendron (Merged PR) Build finished.
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Merged PR) Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

erikjohnston added a commit that referenced this pull request Mar 13, 2017

@erikjohnston
Merge tag 'v0.19.3-rc1' into release-v0.19.3 
Changes in synapse v0.19.3-rc1 (2017-03-08)
===========================================

Features:

* Add some administration functionalities. Thanks to morteza-araby! (PR #1784)

Changes:

* Reduce database table sizes (PR #1873, #1916, #1923, #1963)
* Update contrib/ to not use syutil. Thanks to andrewshadura! (PR #1907)
* Don't fetch current state when sending an event in common case (PR #1955)

Bug fixes:

* Fix synapse_port_db failure. Thanks to Pneumaticat! (PR #1904)
* Fix caching to not cache error responses (PR #1913)
* Fix APIs to make kick & ban reasons work (PR #1917)
* Fix bugs in the /keys/changes api (PR #1921)
* Fix bug where users couldn't forget rooms they were banned from (PR #1922)
* Fix issue with long language values in pushers API (PR #1925)
* Fix a race in transaction queue (PR #1930)
* Fix dynamic thumbnailing to preserve aspect ratio. Thanks to jkolo! (PR
  #1945)
* Fix device list update to not constantly resync (PR #1964)
* Fix potential for huge memory usage when getting device that have
  changed (PR #1969)
8b0f2af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment