/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Make kick & ban reasons work #1917

Merged
merged 1 commit into from Feb 14, 2017

Conversation

Reviewers

@erikjohnston erikjohnston

Assignees

@erikjohnston erikjohnston

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@dbkr @erikjohnston
@dbkr
Member

dbkr commented Feb 14, 2017

We somehow specced APIs with reason strings, preserve the content
in the events and even have the clients display them, but failed
to actually pass the parameter through to the event content.
@dbkr
Make kick & ban reasons work 
We somehow specced APIs with reason strings, preserve the content
in the events  and even have the clients display them, but failed
to actually pass the parameter through to the event content.

Some checks were not successful

1 errored, 1 failing, and 6 successful checks
@matrixbot
Sytest Dendron (Commit) — Build #1530 origin/dbkr/make_ban_reasons_work failed in 11 min
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #2350 origin/dbkr/make_ban_reasons_work succeeded in 5 min 44 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #2417 origin/dbkr/make_ban_reasons_work succeeded in 6 min 6 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
355d62c

@dbkr dbkr requested a review from erikjohnston Feb 14, 2017

@dbkr dbkr assigned erikjohnston Feb 14, 2017

@erikjohnston
Owner

erikjohnston commented Feb 14, 2017

LGTM

@dbkr dbkr merged commit fa467e6 into develop Feb 14, 2017
6 of 8 checks passed

6 of 8 checks passed

Sytest Dendron (Commit) Build #1530 origin/dbkr/make_ban_reasons_work failed in 11 min
Details
Sytest Dendron (Merged PR) Build finished.
Details
Sytest Postgres (Commit) Build #2350 origin/dbkr/make_ban_reasons_work succeeded in 5 min 44 sec
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Commit) Build #2417 origin/dbkr/make_ban_reasons_work succeeded in 6 min 6 sec
Details
Sytest SQLite (Merged PR) Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

erikjohnston added a commit that referenced this pull request Mar 13, 2017

@erikjohnston
Merge tag 'v0.19.3-rc1' into release-v0.19.3 
Changes in synapse v0.19.3-rc1 (2017-03-08)
===========================================

Features:

* Add some administration functionalities. Thanks to morteza-araby! (PR #1784)

Changes:

* Reduce database table sizes (PR #1873, #1916, #1923, #1963)
* Update contrib/ to not use syutil. Thanks to andrewshadura! (PR #1907)
* Don't fetch current state when sending an event in common case (PR #1955)

Bug fixes:

* Fix synapse_port_db failure. Thanks to Pneumaticat! (PR #1904)
* Fix caching to not cache error responses (PR #1913)
* Fix APIs to make kick & ban reasons work (PR #1917)
* Fix bugs in the /keys/changes api (PR #1921)
* Fix bug where users couldn't forget rooms they were banned from (PR #1922)
* Fix issue with long language values in pushers API (PR #1925)
* Fix a race in transaction queue (PR #1930)
* Fix dynamic thumbnailing to preserve aspect ratio. Thanks to jkolo! (PR
  #1945)
* Fix device list update to not constantly resync (PR #1964)
* Fix potential for huge memory usage when getting device that have
  changed (PR #1969)
8b0f2af

@dbkr dbkr deleted the dbkr/make_ban_reasons_work branch Oct 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment