/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix bugs in the /keys/changes api #1921

Merged
merged 1 commit into from Feb 15, 2017

Conversation

Reviewers
No reviews
Assignees

@erikjohnston erikjohnston

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@richvdh @erikjohnston
@richvdh
Member

richvdh commented Feb 15, 2017

  • get_forward_extremeties_for_room takes a numeric stream_ordering. We were
    passing a RoomStreamToken, which meant that it returned the current
    extremities, rather than those corresponding to the from_token. However:
  • get_state_ids_for_events required a second ('types') parameter; this meant
    that a TypeError was thrown and we ended up acting as though there was no
    prev state.
  • get_state_ids_for_events actually returns a map from event_id to state
    dictionary - just looking up the state keys in it again meant that we acted
    as though there was no prev state. We now check if each member's state has
    changed since any of the extremities.

Also add/fix some comments.
@richvdh
Fix bugs in the /keys/changes api 
* `get_forward_extremeties_for_room` takes a numeric `stream_ordering`. We were
  passing a `RoomStreamToken`, which meant that it returned the *current*
  extremities, rather than those corresponding to the `from_token`. However:
* `get_state_ids_for_events` required a second ('types') parameter; this meant
  that a `TypeError` was thrown and we ended up acting as though there was *no*
  prev state.
* `get_state_ids_for_events` actually returns a map from event_id to state
  dictionary - just looking up the state keys in it again meant that we acted
  as though there was no prev state. We now check if each member's state has
  changed since *any* of the extremities.

Also add/fix some comments.

Some checks were not successful

1 errored, 1 failing, and 6 successful checks
@matrixbot
Sytest Dendron (Commit) — Build #1528 origin/rav/fix_key_changes failed in 3 min 37 sec
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #2348 origin/rav/fix_key_changes succeeded in 8 min 6 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #2415 origin/rav/fix_key_changes succeeded in 4 min 49 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
fc2f29c

@richvdh richvdh assigned erikjohnston Feb 15, 2017

@erikjohnston
Owner

erikjohnston commented Feb 15, 2017

LGTM

@richvdh richvdh merged commit 7dcbcca into develop Feb 15, 2017
6 of 8 checks passed

6 of 8 checks passed

Sytest Dendron (Commit) Build #1528 origin/rav/fix_key_changes failed in 3 min 37 sec
Details
Sytest Dendron (Merged PR) Build finished.
Details
Sytest Postgres (Commit) Build #2348 origin/rav/fix_key_changes succeeded in 8 min 6 sec
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Commit) Build #2415 origin/rav/fix_key_changes succeeded in 4 min 49 sec
Details
Sytest SQLite (Merged PR) Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@richvdh richvdh deleted the rav/fix_key_changes branch Mar 8, 2017

erikjohnston added a commit that referenced this pull request Mar 13, 2017

@erikjohnston
Merge tag 'v0.19.3-rc1' into release-v0.19.3 
Changes in synapse v0.19.3-rc1 (2017-03-08)
===========================================

Features:

* Add some administration functionalities. Thanks to morteza-araby! (PR #1784)

Changes:

* Reduce database table sizes (PR #1873, #1916, #1923, #1963)
* Update contrib/ to not use syutil. Thanks to andrewshadura! (PR #1907)
* Don't fetch current state when sending an event in common case (PR #1955)

Bug fixes:

* Fix synapse_port_db failure. Thanks to Pneumaticat! (PR #1904)
* Fix caching to not cache error responses (PR #1913)
* Fix APIs to make kick & ban reasons work (PR #1917)
* Fix bugs in the /keys/changes api (PR #1921)
* Fix bug where users couldn't forget rooms they were banned from (PR #1922)
* Fix issue with long language values in pushers API (PR #1925)
* Fix a race in transaction queue (PR #1930)
* Fix dynamic thumbnailing to preserve aspect ratio. Thanks to jkolo! (PR
  #1945)
* Fix device list update to not constantly resync (PR #1964)
* Fix potential for huge memory usage when getting device that have
  changed (PR #1969)
8b0f2af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment