Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Fix /context/ visibiltiy rules #1929
Conversation
Some checks were not successful
erikjohnston
assigned
NegativeMjark
Feb 20, 2017
| def filter_evts(events): | ||
| return filter_events_for_client( | ||
| self.store, | ||
| user.to_string(), | ||
| events, | ||
| - is_peeking=is_guest | ||
| + is_peeking=is_peeking |
NegativeMjark
Feb 20, 2017
Contributor
Do we still need the is_guest parameter in get_event_context? If you are leaving it could you add some docstring to indicate it is unused?
Some checks were not successful
erikjohnston
merged commit b5c2687
into
develop
Feb 20, 2017
5 of 8 checks passed
Sytest Dendron (Commit)
Build #1556 origin/erikj/context_fix failed in 12 min
Details
Sytest Dendron (Merged PR)
Build finished.
Details
Sytest Postgres (Merged PR)
Build started sha1 is merged.
Details
Sytest Postgres (Commit)
Build #2377 origin/erikj/context_fix succeeded in 7 min 4 sec
Details
Sytest SQLite (Commit)
Build #2440 origin/erikj/context_fix succeeded in 5 min 48 sec
Details
Sytest SQLite (Merged PR)
Build finished.
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
continuous-integration/travis-ci/push
The Travis CI build passed
Details
erikjohnston
deleted the
erikj/context_fix
branch
Mar 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
erikjohnston commentedFeb 20, 2017
No description provided.