/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Clobber old device list stream entries #1963

Merged
merged 3 commits into from Mar 3, 2017
+34 −0

Conversation

Reviewers

@NegativeMjark NegativeMjark

Assignees

@NegativeMjark NegativeMjark

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@erikjohnston @NegativeMjark
@erikjohnston
Owner

erikjohnston commented Mar 1, 2017

No description provided.

@erikjohnston
Clobber old device list stream entries

Some checks were not successful

1 failing and 7 successful checks
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Dendron (Commit) — Build #1597 origin/erikj/delete_old_device_streams succeeded in 13 min
Details
@matrixbot
Sytest Postgres (Commit) — Build #2416 origin/erikj/delete_old_device_streams succeeded in 7 min 31 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #2481 origin/erikj/delete_old_device_streams succeeded in 6 min 31 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
3365117

@erikjohnston erikjohnston assigned NegativeMjark Mar 1, 2017

@erikjohnston
Add index to device_lists_stream

Some checks were not successful

1 errored and 7 successful checks
@matrixbot
Sytest Dendron (Commit) — Build #1602 origin/erikj/delete_old_device_streams failed in 3.7 sec
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #2419 origin/erikj/delete_old_device_streams succeeded in 6 min 54 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #2484 origin/erikj/delete_old_device_streams succeeded in 5 min 3 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
d766343
synapse/storage/deviceinbox.py
+ "device_lists_stream_idx",
+ index_name="device_lists_stream_user_id",
+ table="device_lists_stream",
+ columns=["user_id", "device_id"],
@NegativeMjark

NegativeMjark Mar 2, 2017

Contributor

Umm, What happened to the (stream_id, user_id) index?
Should the new index be called device_lists_stream_user_id_device_id?

@erikjohnston

erikjohnston Mar 2, 2017

Owner

Ha, I got confused after copy pasting...

synapse/storage/devices.py
+ self.register_background_index_update(
+ "device_inbox_stream_index",
+ index_name="device_inbox_stream_id_user_id",
+ table="device_inbox",
@NegativeMjark

NegativeMjark Mar 2, 2017

Contributor

Why isn't this in the device_inbox file anymore?

synapse/storage/schema/delta/41/device_list_stream_idx.sql
+ */
+
+INSERT into background_updates (update_name, progress_json)
+ VALUES ('device_lists_stream_idx', '{}');
@NegativeMjark

NegativeMjark Mar 2, 2017

Contributor

Is calling this idx or index more consistent with what came before?

@erikjohnston

erikjohnston Mar 3, 2017

Owner

There's a mix

@erikjohnston
Fix up

Some checks were not successful

2 errored and 6 successful checks
@matrixbot
Sytest Dendron (Commit) — Build #1607 origin/erikj/delete_old_device_streams failed in 11 sec
Details
@matrixbot
Sytest Postgres (Commit) — Build #2423 origin/erikj/delete_old_device_streams failed in 8 min 29 sec
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #2488 origin/erikj/delete_old_device_streams succeeded in 6 min 2 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
da52d3a
@erikjohnston
Owner

erikjohnston commented Mar 3, 2017

@NegativeMjark PTAL

@erikjohnston erikjohnston merged commit 96d79bb into develop Mar 3, 2017
6 of 8 checks passed

6 of 8 checks passed

Sytest Dendron (Commit) Build #1607 origin/erikj/delete_old_device_streams failed in 11 sec
Details
Sytest Postgres (Commit) Build #2423 origin/erikj/delete_old_device_streams failed in 8 min 29 sec
Details
Sytest Dendron (Merged PR) Build finished.
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Commit) Build #2488 origin/erikj/delete_old_device_streams succeeded in 6 min 2 sec
Details
Sytest SQLite (Merged PR) Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

erikjohnston added a commit that referenced this pull request Mar 13, 2017

@erikjohnston
Merge tag 'v0.19.3-rc1' into release-v0.19.3 
Changes in synapse v0.19.3-rc1 (2017-03-08)
===========================================

Features:

* Add some administration functionalities. Thanks to morteza-araby! (PR #1784)

Changes:

* Reduce database table sizes (PR #1873, #1916, #1923, #1963)
* Update contrib/ to not use syutil. Thanks to andrewshadura! (PR #1907)
* Don't fetch current state when sending an event in common case (PR #1955)

Bug fixes:

* Fix synapse_port_db failure. Thanks to Pneumaticat! (PR #1904)
* Fix caching to not cache error responses (PR #1913)
* Fix APIs to make kick & ban reasons work (PR #1917)
* Fix bugs in the /keys/changes api (PR #1921)
* Fix bug where users couldn't forget rooms they were banned from (PR #1922)
* Fix issue with long language values in pushers API (PR #1925)
* Fix a race in transaction queue (PR #1930)
* Fix dynamic thumbnailing to preserve aspect ratio. Thanks to jkolo! (PR
  #1945)
* Fix device list update to not constantly resync (PR #1964)
* Fix potential for huge memory usage when getting device that have
  changed (PR #1969)
8b0f2af

@erikjohnston erikjohnston deleted the erikj/delete_old_device_streams branch Mar 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment