/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix device list update to not constantly resync #1964

Merged
merged 3 commits into from Mar 3, 2017

Conversation

Reviewers

@NegativeMjark NegativeMjark

Assignees

@NegativeMjark NegativeMjark

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@erikjohnston @NegativeMjark
@erikjohnston
Owner

erikjohnston commented Mar 1, 2017

No description provided.

@erikjohnston
Fix device list update to not constantly resync

Some checks were not successful

1 failing and 7 successful checks
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Dendron (Commit) — Build #1598 origin/erikj/device_list_update_fix succeeded in 13 min
Details
@matrixbot
Sytest Postgres (Commit) — Build #2417 origin/erikj/device_list_update_fix succeeded in 7 min 12 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #2482 origin/erikj/device_list_update_fix succeeded in 6 min 11 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
36be39b

@erikjohnston erikjohnston assigned NegativeMjark Mar 1, 2017

synapse/handlers/device.py
+ @defer.inlineCallbacks
+ def _handle_device_updates(self, user_id):
+ "Actually handle pending updates."
+
with (yield self._remote_edue_linearizer.queue(user_id)):
@NegativeMjark

NegativeMjark Mar 2, 2017

Contributor

"edue"?

synapse/handlers/device.py
+ if prev_id == extremity:
+ continue
+ elif prev_id in seen_updates:
+ continue
@NegativeMjark

NegativeMjark Mar 2, 2017

Contributor

Could we remove the prev_id from the seen_updates here?

@erikjohnston

erikjohnston Mar 3, 2017

Owner

Possibly, but I'd rather keep it simple and just keep the most recently seen stream_ids.

erikjohnston added some commits Mar 3, 2017

@erikjohnston
Spelling
9834367
@erikjohnston
Don't keep around old stream IDs forever

Some checks were not successful

1 errored and 7 successful checks
@matrixbot
Sytest Dendron (Commit) — Build #1608 origin/erikj/device_list_update_fix failed in 7.5 sec
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #2424 origin/erikj/device_list_update_fix succeeded in 7 min 24 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #2489 origin/erikj/device_list_update_fix succeeded in 6 min 6 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
f2581ee
@erikjohnston
Owner

erikjohnston commented Mar 3, 2017

@NegativeMjark PTAL

@erikjohnston erikjohnston merged commit 82f7f15 into develop Mar 3, 2017
7 of 8 checks passed

7 of 8 checks passed

Sytest Dendron (Commit) Build #1608 origin/erikj/device_list_update_fix failed in 7.5 sec
Details
Sytest Dendron (Merged PR) Build finished.
Details
Sytest Postgres (Commit) Build #2424 origin/erikj/device_list_update_fix succeeded in 7 min 24 sec
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Commit) Build #2489 origin/erikj/device_list_update_fix succeeded in 6 min 6 sec
Details
Sytest SQLite (Merged PR) Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@richvdh richvdh referenced this pull request Mar 8, 2017

Closed

device_list_stream is stored inefficiently, leading to massive disk space use #1962

erikjohnston added a commit that referenced this pull request Mar 13, 2017

@erikjohnston
Merge tag 'v0.19.3-rc1' into release-v0.19.3 
Changes in synapse v0.19.3-rc1 (2017-03-08)
===========================================

Features:

* Add some administration functionalities. Thanks to morteza-araby! (PR #1784)

Changes:

* Reduce database table sizes (PR #1873, #1916, #1923, #1963)
* Update contrib/ to not use syutil. Thanks to andrewshadura! (PR #1907)
* Don't fetch current state when sending an event in common case (PR #1955)

Bug fixes:

* Fix synapse_port_db failure. Thanks to Pneumaticat! (PR #1904)
* Fix caching to not cache error responses (PR #1913)
* Fix APIs to make kick & ban reasons work (PR #1917)
* Fix bugs in the /keys/changes api (PR #1921)
* Fix bug where users couldn't forget rooms they were banned from (PR #1922)
* Fix issue with long language values in pushers API (PR #1925)
* Fix a race in transaction queue (PR #1930)
* Fix dynamic thumbnailing to preserve aspect ratio. Thanks to jkolo! (PR
  #1945)
* Fix device list update to not constantly resync (PR #1964)
* Fix potential for huge memory usage when getting device that have
  changed (PR #1969)
8b0f2af

@erikjohnston erikjohnston deleted the erikj/device_list_update_fix branch Mar 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment