/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Select distinct devices from DB #1969

Merged
merged 1 commit into from Mar 6, 2017

Conversation

Reviewers

@NegativeMjark NegativeMjark

Assignees

@NegativeMjark NegativeMjark

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@erikjohnston @NegativeMjark
@erikjohnston
Owner

erikjohnston commented Mar 6, 2017

Otherwise we might pull out tonnes of duplicate user_ids and this can
make synapse sad.
@erikjohnston
Select distinct devices from DB 
Otherwise we might pull out tonnes of duplicate user_ids and this can
make synapse sad.

Some checks were not successful

1 failing and 7 successful checks
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Dendron (Commit) — Build #1613 origin/erikj/get_distinct_devices succeeded in 12 min
Details
@matrixbot
Sytest Postgres (Commit) — Build #2429 origin/erikj/get_distinct_devices succeeded in 7 min 46 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #2494 origin/erikj/get_distinct_devices succeeded in 5 min 47 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
ac5491f

@erikjohnston erikjohnston assigned NegativeMjark Mar 6, 2017

@NegativeMjark
Contributor

NegativeMjark commented Mar 6, 2017

LGTM

@erikjohnston erikjohnston merged commit c98d91f into develop Mar 6, 2017
7 of 8 checks passed

7 of 8 checks passed

Sytest Dendron (Merged PR) Build finished.
Details
Sytest Dendron (Commit) Build #1613 origin/erikj/get_distinct_devices succeeded in 12 min
Details
Sytest Postgres (Commit) Build #2429 origin/erikj/get_distinct_devices succeeded in 7 min 46 sec
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Commit) Build #2494 origin/erikj/get_distinct_devices succeeded in 5 min 47 sec
Details
Sytest SQLite (Merged PR) Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@richvdh richvdh referenced this pull request Mar 8, 2017

Closed

device_list_stream is stored inefficiently, leading to massive disk space use #1962

erikjohnston added a commit that referenced this pull request Mar 13, 2017

@erikjohnston
Merge tag 'v0.19.3-rc1' into release-v0.19.3 
Changes in synapse v0.19.3-rc1 (2017-03-08)
===========================================

Features:

* Add some administration functionalities. Thanks to morteza-araby! (PR #1784)

Changes:

* Reduce database table sizes (PR #1873, #1916, #1923, #1963)
* Update contrib/ to not use syutil. Thanks to andrewshadura! (PR #1907)
* Don't fetch current state when sending an event in common case (PR #1955)

Bug fixes:

* Fix synapse_port_db failure. Thanks to Pneumaticat! (PR #1904)
* Fix caching to not cache error responses (PR #1913)
* Fix APIs to make kick & ban reasons work (PR #1917)
* Fix bugs in the /keys/changes api (PR #1921)
* Fix bug where users couldn't forget rooms they were banned from (PR #1922)
* Fix issue with long language values in pushers API (PR #1925)
* Fix a race in transaction queue (PR #1930)
* Fix dynamic thumbnailing to preserve aspect ratio. Thanks to jkolo! (PR
  #1945)
* Fix device list update to not constantly resync (PR #1964)
* Fix potential for huge memory usage when getting device that have
  changed (PR #1969)
8b0f2af

@erikjohnston erikjohnston deleted the erikj/get_distinct_devices branch Mar 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment