/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Speed up public room list #1989

Merged
merged 5 commits into from Mar 14, 2017

Conversation

Reviewers

@NegativeMjark NegativeMjark

Assignees

@NegativeMjark NegativeMjark

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@erikjohnston @NegativeMjark @lampholder
@erikjohnston
Owner

erikjohnston commented Mar 13, 2017

The function get_order_for_room was taking up a lot of time.

erikjohnston added some commits Mar 10, 2017

@erikjohnston
Get current state by using current_state_events table
8ffbe43
@erikjohnston
Assume rooms likely haven't changed

Some checks were not successful

2 errored and 2 successful checks
@matrixbot
Sytest Dendron (Commit) — Build #1649 origin/erikj/public_list_speed failed in 12 min
Details
@matrixbot
Sytest Postgres (Commit) — Build #2464 origin/erikj/public_list_speed failed in 7 min 18 sec
Details
@matrixbot
Sytest SQLite (Commit) — Build #2529 origin/erikj/public_list_speed succeeded in 4 min 26 sec
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
79926e0
@erikjohnston
Comments

Some checks were not successful

1 errored, 2 failing, and 5 successful checks
@matrixbot
Sytest Dendron (Commit) — Build #1652 origin/erikj/public_list_speed failed in 12 min
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #2465 origin/erikj/public_list_speed succeeded in 7 min 23 sec
Details
@matrixbot
Sytest SQLite (Commit) — Build #2530 origin/erikj/public_list_speed succeeded in 5 min 25 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
0162994

@erikjohnston erikjohnston assigned NegativeMjark Mar 13, 2017

@lampholder lampholder added the in progress label Mar 13, 2017

@erikjohnston
Add new storage function to slave store

Some checks were not successful

2 errored, 1 failing, and 5 successful checks
@matrixbot
Sytest Dendron (Commit) — Build #1660 origin/erikj/public_list_speed failed in 13 min
Details
@matrixbot
Sytest SQLite (Commit) — Build #2539 origin/erikj/public_list_speed failed in 6 min 47 sec
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #2473 origin/erikj/public_list_speed succeeded in 7 min 34 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
45c7f12

@erikjohnston erikjohnston unassigned NegativeMjark Mar 13, 2017

@erikjohnston
Merge branch 'develop' of github.com:matrix-org/synapse into erikj/pu… 
…blic_list_speed

Some checks were not successful

1 errored, 1 failing, and 6 successful checks
@matrixbot
Sytest Dendron (Commit) — Build #1671 origin/erikj/public_list_speed failed in 14 min
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #2486 origin/erikj/public_list_speed succeeded in 8 min 24 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #2552 origin/erikj/public_list_speed succeeded in 5 min 22 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
bb256ac

@erikjohnston erikjohnston assigned NegativeMjark Mar 14, 2017

@lampholder lampholder removed the in progress label Mar 14, 2017

@NegativeMjark

NegativeMjark approved these changes Mar 14, 2017
View changes

LGTM?

@erikjohnston erikjohnston merged commit 1bf84c4 into develop Mar 14, 2017
6 of 8 checks passed

6 of 8 checks passed

Sytest Dendron (Commit) Build #1671 origin/erikj/public_list_speed failed in 14 min
Details
Sytest Dendron (Merged PR) Build finished.
Details
Sytest Postgres (Commit) Build #2486 origin/erikj/public_list_speed succeeded in 8 min 24 sec
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Commit) Build #2552 origin/erikj/public_list_speed succeeded in 5 min 22 sec
Details
Sytest SQLite (Merged PR) Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@erikjohnston erikjohnston referenced this pull request Mar 20, 2017

Closed

client-reader worker can leak FDs and then swallow requests #1981

@erikjohnston erikjohnston deleted the erikj/public_list_speed branch Oct 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment