Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Phone number registration / login support v2 #1994
Conversation
dbkr
added some commits
Mar 13, 2017
All checks have passed
Sytest Postgres (Commit)
— Build #2478 origin/dbkr/msisdn_signin_2 succeeded in 7 min 32 sec
lampholder
added
the
in progress
label
Mar 13, 2017
dbkr
assigned
erikjohnston
Mar 14, 2017
| + # Android <=0.6.9 have fallen below an acceptable threshold, this | ||
| + # parameter should go away and we should always advertise msisdn flows. | ||
| + show_msisdn = False | ||
| + print body |
| + flows += [ | ||
| + [LoginType.MSISDN, LoginType.RECAPTCHA], | ||
| + [LoginType.MSISDN, LoginType.EMAIL_IDENTITY, LoginType.RECAPTCHA], | ||
| + ] |
erikjohnston
Mar 14, 2017
Owner
Generally we prefer flows.extend([..]) rather than concatenating two lists, but meh
dbkr
Mar 14, 2017
Member
Ah interesting, I wrote that first but then sort of concluded the opposite.
dbkr
added some commits
Mar 14, 2017
Some checks were not successful
Sytest Postgres (Commit)
— Build #2481 origin/dbkr/msisdn_signin_2 succeeded in 8 min 17 sec
Some checks were not successful
Sytest Postgres (Commit)
— Build #2482 origin/dbkr/msisdn_signin_2 succeeded in 7 min 20 sec
lampholder
removed
the
in progress
label
Mar 14, 2017
erikjohnston
merged commit 7827251
into
develop
Mar 15, 2017
7 of 8 checks passed
Sytest Dendron (Merged PR)
Build finished.
Details
Sytest Dendron (Commit)
Build #1669 origin/dbkr/msisdn_signin_2 succeeded in 14 min
Details
Sytest Postgres (Commit)
Build #2482 origin/dbkr/msisdn_signin_2 succeeded in 7 min 20 sec
Details
Sytest Postgres (Merged PR)
Build finished.
Details
Sytest SQLite (Commit)
Build #2548 origin/dbkr/msisdn_signin_2 succeeded in 6 min 35 sec
Details
Sytest SQLite (Merged PR)
Build finished.
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
continuous-integration/travis-ci/push
The Travis CI build passed
Details
|
lgtm |
dbkr
deleted the
dbkr/msisdn_signin_2
branch
Oct 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
dbkr commentedMar 13, 2017
•
edited
#1971 with fix for old clients
Presented in two parts (commits)