/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix current_state_events table to not lie #1996

Merged
merged 1 commit into from Mar 14, 2017

Conversation

Reviewers

@NegativeMjark NegativeMjark

Assignees

@NegativeMjark NegativeMjark

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@erikjohnston @NegativeMjark @lampholder
@erikjohnston
Owner

erikjohnston commented Mar 14, 2017

If we try and persist two state events that have the same ancestor we
calculate the wrong current state when persisting those events.
@erikjohnston
Fix current_state_events table to not lie 
If we try and persist two state events that have the same ancestor we
calculate the wrong current state when persisting those events.

Some checks were not successful

1 errored, 1 failing, and 6 successful checks
@matrixbot
Sytest Dendron (Commit) — Build #1670 origin/erikj/fix_current_state failed in 15 min
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #2483 origin/erikj/fix_current_state succeeded in 7 min 46 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #2549 origin/erikj/fix_current_state succeeded in 5 min 55 sec
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
cc7a294

@erikjohnston erikjohnston assigned NegativeMjark Mar 14, 2017

@lampholder lampholder added the in progress label Mar 14, 2017

@erikjohnston erikjohnston merged commit 6a3c5d6 into develop Mar 14, 2017
6 of 8 checks passed

6 of 8 checks passed

Sytest SQLite (Merged PR) Build finished.
Details
Sytest Dendron (Commit) Build #1670 origin/erikj/fix_current_state in progress...
Details
Sytest Dendron (Merged PR) Build finished.
Details
Sytest Postgres (Commit) Build #2483 origin/erikj/fix_current_state succeeded in 7 min 46 sec
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Commit) Build #2549 origin/erikj/fix_current_state succeeded in 5 min 55 sec
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@lampholder lampholder removed the in progress label Mar 14, 2017

@richvdh richvdh referenced this pull request Apr 7, 2017

Closed

Cannot accept/reject a third invite to a room #1987

@erikjohnston erikjohnston deleted the erikj/fix_current_state branch Oct 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment