/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Reduce number of spurious sync result generations. #2002

Merged
merged 1 commit into from Mar 14, 2017

Conversation

Reviewers

@NegativeMjark NegativeMjark

Assignees

@NegativeMjark NegativeMjark

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@erikjohnston @NegativeMjark
@erikjohnston
Owner

erikjohnston commented Mar 14, 2017

Currently for every /sync we always generate a sync result before waiting on the notifier. This changes that so that we instead rely on the notifier waking up the stream immediately if something has happened since the token specified.
@erikjohnston
Reduce spurious calls to generate sync

Some checks were not successful

1 errored and 7 successful checks
@matrixbot
Sytest Dendron (Commit) — Build #1680 origin/erikj/dont_sync_by_default failed in 13 min
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #2496 origin/erikj/dont_sync_by_default succeeded in 8 min 15 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #2562 origin/erikj/dont_sync_by_default succeeded in 5 min 27 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
fd2eef4

@erikjohnston erikjohnston assigned NegativeMjark Mar 14, 2017

@erikjohnston erikjohnston merged commit bad72b0 into develop Mar 14, 2017
7 of 8 checks passed

7 of 8 checks passed

Sytest Dendron (Commit) Build #1680 origin/erikj/dont_sync_by_default in progress...
Details
Sytest Dendron (Merged PR) Build finished.
Details
Sytest Postgres (Commit) Build #2496 origin/erikj/dont_sync_by_default succeeded in 8 min 15 sec
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Commit) Build #2562 origin/erikj/dont_sync_by_default succeeded in 5 min 27 sec
Details
Sytest SQLite (Merged PR) Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@erikjohnston erikjohnston deleted the erikj/dont_sync_by_default branch Oct 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment