/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix caching of remote servers' signature keys #2042

Merged
merged 1 commit into from Mar 22, 2017

Conversation

Reviewers
No reviews
Assignees

@erikjohnston erikjohnston

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@richvdh @erikjohnston
@richvdh
Member

richvdh commented Mar 22, 2017

The @cached decorator on KeyStore._get_server_verify_key was missing its num_args parameter, which meant that it was returning the wrong key for any server which had more than one recorded key.

By way of a fix, change the default for num_args to be all arguments. To implement that, factor out a common base class for CacheDescriptor and CacheListDescriptor.

Fixes #2034.
@richvdh
Fix caching of remote servers' signature keys 
The `@cached` decorator on `KeyStore._get_server_verify_key` was missing
its `num_args` parameter, which meant that it was returning the wrong key for
any server which had more than one recorded key.

By way of a fix, change the default for `num_args` to be *all* arguments. To
implement that, factor out a common base class for `CacheDescriptor` and `CacheListDescriptor`.

Some checks were not successful

1 errored, 2 failing, and 5 successful checks
@matrixbot
Sytest Dendron (Commit) — Build #1768 origin/rav/fix_key_caching failed in 12 min
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #2589 origin/rav/fix_key_caching succeeded in 7 min 59 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #2663 origin/rav/fix_key_caching succeeded in 5 min 39 sec
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
95f21c7

@richvdh richvdh assigned erikjohnston Mar 22, 2017

@erikjohnston
Owner

erikjohnston commented Mar 22, 2017

lgtm

@richvdh richvdh merged commit 7b67848 into develop Mar 22, 2017
5 of 8 checks passed

5 of 8 checks passed

Sytest Dendron (Commit) Build #1768 origin/rav/fix_key_caching failed in 12 min
Details
Sytest Dendron (Merged PR) Build finished.
Details
Sytest SQLite (Merged PR) Build finished.
Details
Sytest Postgres (Commit) Build #2589 origin/rav/fix_key_caching succeeded in 7 min 59 sec
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Commit) Build #2663 origin/rav/fix_key_caching succeeded in 5 min 39 sec
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@richvdh richvdh deleted the rav/fix_key_caching branch Mar 22, 2017

@richvdh richvdh referenced this pull request Mar 22, 2017

Closed

obscure federation authentication failure #2034

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment