Reduce some CPU work on DB threads #2054

Merged

erikjohnston merged 3 commits into develop from erikj/user_iter_cursor

Mar 24, 2017

Owner

erikjohnston commented Mar 23, 2017 • edited

This prevents unnecessary construction of lists and other things in the DB threads


      User Cursor.__iter__ instead of fetchall

This prevents unnecessary construction of lists

00957d1

erikjohnston assigned richvdh Mar 23, 2017


      Use iter(items|values)

e71940a

erikjohnston changed the title from User Cursor.iter instead of fetchall to Reduce some CPU work on DB threads Mar 24, 2017


      Replace some calls to cursor_to_dict

cursor_to_dict can be surprisinglh expensive for large result sets, so lets
only call it when we need to.

d58b1ff

Owner

erikjohnston commented Mar 24, 2017

The commits should be self contained

richvdh approved these changes Mar 24, 2017

View changes

you've been having fun.

lgtm

richvdh assigned erikjohnston and unassigned richvdh Mar 24, 2017

erikjohnston merged commit `57cfa51` into develop Mar 24, 2017
7 of 8 checks passed

7 of 8 checks passed

Sytest Dendron (Merged PR) Build finished.

Details

Sytest Dendron (Commit) Build #1799 origin/erikj/user_iter_cursor succeeded in 12 min

Details

Sytest Postgres (Commit) Build #2620 origin/erikj/user_iter_cursor succeeded in 6 min 34 sec

Details

Sytest Postgres (Merged PR) Build finished.

Details

Sytest SQLite (Commit) Build #2693 origin/erikj/user_iter_cursor succeeded in 7 min 0 sec

Details

Sytest SQLite (Merged PR) Build finished.

Details

continuous-integration/travis-ci/pr The Travis CI build passed

Details

continuous-integration/travis-ci/push The Travis CI build passed

Details

erikjohnston deleted the erikj/user_iter_cursor branch Oct 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can't perform that action at this time.