/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

try not to drop context after federation requests #2058

Merged
merged 1 commit into from Mar 24, 2017

Conversation

Reviewers
No reviews
Assignees

@erikjohnston erikjohnston

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@richvdh @erikjohnston
@richvdh
Member

richvdh commented Mar 23, 2017

preserve_context_over_fn uses a ContextPreservingDeferred, which only restores
context for the duration of its callbacks, which isn't really correct, and
means that subsequent operations in the same request can end up without their
logcontexts.
@richvdh
try not to drop context after federation requests 
preserve_context_over_fn uses a ContextPreservingDeferred, which only restores
context for the duration of its callbacks, which isn't really correct, and
means that subsequent operations in the same request can end up without their
logcontexts.

Some checks were not successful

1 errored, 1 failing, and 6 successful checks
@matrixbot
Sytest Dendron (Commit) — Build #1796 origin/rav/logcontext_leaks_2 failed in 13 min
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #2618 origin/rav/logcontext_leaks_2 succeeded in 7 min 31 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #2691 origin/rav/logcontext_leaks_2 succeeded in 6 min 25 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
a380f04

@richvdh richvdh assigned erikjohnston Mar 23, 2017

@erikjohnston
Owner

erikjohnston commented Mar 24, 2017

lgtm

@richvdh richvdh merged commit f136c89 into develop Mar 24, 2017
6 of 8 checks passed

6 of 8 checks passed

Sytest Dendron (Commit) Build #1796 origin/rav/logcontext_leaks_2 failed in 13 min
Details
Sytest Dendron (Merged PR) Build finished.
Details
Sytest Postgres (Commit) Build #2618 origin/rav/logcontext_leaks_2 succeeded in 7 min 31 sec
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Commit) Build #2691 origin/rav/logcontext_leaks_2 succeeded in 6 min 25 sec
Details
Sytest SQLite (Merged PR) Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@richvdh richvdh deleted the rav/logcontext_leaks_2 branch Oct 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment