Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Accept join events from all servers #2094
Conversation
Some checks were not successful
richvdh
assigned
erikjohnston
Apr 3, 2017
|
lgtm |
richvdh
merged commit ac63b92
into
release-v0.20.0
Apr 3, 2017
3 of 5 checks passed
Sytest Dendron (Merged PR)
Build finished.
Details
Sytest Postgres (Merged PR)
Build started sha1 is merged.
Details
Sytest SQLite (Merged PR)
Build finished.
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
continuous-integration/travis-ci/push
The Travis CI build passed
Details
kroeckx
commented
Apr 3, 2017
|
Does this mean all servers forward all joins, and that you would end up with the situation again seeing them multiple times? |
|
No, only the helping server forwards the join (modulo #1753, which was fixed in synapse 0.18.7). |
richvdh
deleted the
rav/fix_federation_join
branch
Oct 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
richvdh commentedApr 3, 2017
Make sure that we accept join events from any server, rather than just the
origin server, to make the federation join dance work correctly.
(Fixes #1893).