Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Remove HTTP replication APIs #2117
Conversation
erikjohnston
assigned
richvdh
Apr 11, 2017
richvdh
approved these changes
Apr 11, 2017
looks good, but it reminds me that https://github.com/matrix-org/synapse/blob/develop/docs/workers.rst and https://github.com/matrix-org/synapse/blob/develop/docs/replication.rst are now lies.
richvdh
assigned
erikjohnston
and unassigned
richvdh
Apr 11, 2017
erikjohnston
added some commits
Apr 11, 2017
|
Oops, I didn't notice you approved rather than requested changes. I've updated those docs anyway. |
erikjohnston
assigned
richvdh
and unassigned
erikjohnston
Apr 11, 2017
| @@ -57,7 +52,8 @@ For instance:: | ||
| worker_app: synapse.app.synchrotron | ||
| # The replication listener on the synapse to talk to. | ||
| - worker_replication_url: http://127.0.0.1:9092/_synapse/replication |
richvdh
Apr 12, 2017
Member
there is still a reference to worker_replication_url in the previous para
well, great result :) |
richvdh
assigned
erikjohnston
and unassigned
richvdh
Apr 12, 2017
erikjohnston
merged commit bf90601
into
develop
Apr 12, 2017
0 of 5 checks passed
Sytest Dendron (Merged PR)
Build triggered. sha1 is merged.
Details
Sytest Postgres (Merged PR)
Build started sha1 is merged.
Details
Sytest SQLite (Merged PR)
Build started sha1 is merged.
Details
continuous-integration/travis-ci/pr
The Travis CI build is in progress
Details
continuous-integration/travis-ci/push
The Travis CI build is in progress
Details
psaavedra
added a commit
to psaavedra/synapse
that referenced
this pull request
May 19, 2017
erikjohnston
deleted the
erikj/remove_http_replication
branch
Oct 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
erikjohnston commentedApr 11, 2017
No description provided.