/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix getting latest device IP for user with no devices #2118

Merged
merged 3 commits into from Apr 12, 2017

Conversation

Reviewers

@richvdh richvdh

Assignees

@erikjohnston erikjohnston

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@erikjohnston @richvdh
@erikjohnston
Owner

erikjohnston commented Apr 11, 2017

@richvdh This seems to have been hit by a guest, whom I'm assuming doesn't have any devices?
@erikjohnston
Fix getting latest device IP for user with no devices

Some checks were not successful

1 errored and 7 successful checks
@matrixbot
Sytest Dendron (Commit) — Build #1944 origin/erikj/no_devices failed in 8 min 57 sec
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #2773 origin/erikj/no_devices succeeded in 7 min 20 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #2843 origin/erikj/no_devices succeeded in 5 min 59 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
34840cd

@erikjohnston erikjohnston assigned richvdh Apr 11, 2017

synapse/storage/client_ips.py
@@ -90,6 +90,8 @@ def get_last_client_ip_by_device(self, devices):
are (user_id, device_id) tuples. The values are also dicts, with
keys giving the column names
"""
+ if not devices:
@richvdh

richvdh Apr 11, 2017

Member

the docstring says devices is an iterable rather than a list, and indeed there are call-sites where it is a generator. An empty generator is truthy, so this isn't going to work.

My inclination would be to skip this and instead bail if where_clauses ends up empty.

@richvdh
Member

richvdh commented Apr 11, 2017

@richvdh This seems to have been hit by a guest, whom I'm assuming doesn't have any devices?

Yup guests won't have any devices in the db.

@richvdh richvdh assigned erikjohnston and unassigned richvdh Apr 11, 2017

erikjohnston added some commits Apr 11, 2017

@erikjohnston
Don't bother with outer check for now

All checks have passed

5 successful checks
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
b48045a
@erikjohnston
Bail on where clause instead

Some checks were not successful

1 errored and 7 successful checks
@matrixbot
Sytest SQLite (Commit) — Build #2853 origin/erikj/no_devices failed in 6 min 6 sec
Details
@matrixbot
Sytest Dendron (Commit) — Build #1954 origin/erikj/no_devices succeeded in 9 min 22 sec
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #2784 origin/erikj/no_devices succeeded in 7 min 9 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
85657ee

@erikjohnston erikjohnston assigned richvdh and unassigned erikjohnston Apr 11, 2017

@richvdh

richvdh approved these changes Apr 12, 2017
View changes

lgtm

@richvdh richvdh assigned erikjohnston and unassigned richvdh Apr 12, 2017

@erikjohnston erikjohnston merged commit 7b41013 into develop Apr 12, 2017
7 of 8 checks passed

7 of 8 checks passed

Sytest SQLite (Commit) Build #2853 origin/erikj/no_devices failed in 6 min 6 sec
Details
Sytest Dendron (Commit) Build #1954 origin/erikj/no_devices succeeded in 9 min 22 sec
Details
Sytest Dendron (Merged PR) Build finished.
Details
Sytest Postgres (Commit) Build #2784 origin/erikj/no_devices succeeded in 7 min 9 sec
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Merged PR) Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

psaavedra added a commit to psaavedra/synapse that referenced this pull request May 19, 2017

@psaavedra
Merge tag 'v0.21.0' into v0.21.0_no_federate_by_default 
Changes in synapse v0.21.0 (2017-05-18)
=======================================

No changes since v0.21.0-rc3

Changes in synapse v0.21.0-rc3 (2017-05-17)
===========================================

Features:

* Add per user rate-limiting overrides (PR #2208)
* Add config option to limit maximum number of events requested by ``/sync``
  and ``/messages`` (PR #2221) Thanks to @psaavedra!

Changes:

* Various small performance fixes (PR #2201, #2202, #2224, #2226, #2227, #2228,
  #2229)
* Update username availability checker API (PR #2209, #2213)
* When purging, don't de-delta state groups we're about to delete (PR #2214)
* Documentation to check synapse version (PR #2215) Thanks to @hamber-dick!
* Add an index to event_search to speed up purge history API (PR #2218)

Bug fixes:

* Fix API to allow clients to upload one-time-keys with new sigs (PR #2206)

Changes in synapse v0.21.0-rc2 (2017-05-08)
===========================================

Changes:

* Always mark remotes as up if we receive a signed request from them (PR #2190)

Bug fixes:

* Fix bug where users got pushed for rooms they had muted (PR #2200)

Changes in synapse v0.21.0-rc1 (2017-05-08)
===========================================

Features:

* Add username availability checker API (PR #2183)
* Add read marker API (PR #2120)

Changes:

* Enable guest access for the 3pl/3pid APIs (PR #1986)
* Add setting to support TURN for guests (PR #2011)
* Various performance improvements (PR #2075, #2076, #2080, #2083, #2108,
  #2158, #2176, #2185)
* Make synctl a bit more user friendly (PR #2078, #2127) Thanks @APwhitehat!
* Replace HTTP replication with TCP replication (PR #2082, #2097, #2098,
  #2099, #2103, #2014, #2016, #2115, #2116, #2117)
* Support authenticated SMTP (PR #2102) Thanks @DanielDent!
* Add a counter metric for successfully-sent transactions (PR #2121)
* Propagate errors sensibly from proxied IS requests (PR #2147)
* Add more granular event send metrics (PR #2178)

Bug fixes:

* Fix nuke-room script to work with current schema (PR #1927) Thanks
  @zuckschwerdt!
* Fix db port script to not assume postgres tables are in the public schema
  (PR #2024) Thanks @jerrykan!
* Fix getting latest device IP for user with no devices (PR #2118)
* Fix rejection of invites to unreachable servers (PR #2145)
* Fix code for reporting old verify keys in synapse (PR #2156)
* Fix invite state to always include all events (PR #2163)
* Fix bug where synapse would always fetch state for any missing event (PR #2170)
* Fix a leak with timed out HTTP connections (PR #2180)
* Fix bug where we didn't time out HTTP requests to ASes  (PR #2192)

Docs:

* Clarify doc for SQLite to PostgreSQL port (PR #1961) Thanks @benhylau!
* Fix typo in synctl help (PR #2107) Thanks @HarHarLinks!
* ``web_client_location`` documentation fix (PR #2131) Thanks @matthewjwolff!
* Update README.rst with FreeBSD changes (PR #2132) Thanks @feld!
* Clarify setting up metrics (PR #2149) Thanks @encks!
badd30b

@erikjohnston erikjohnston deleted the erikj/no_devices branch Oct 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment