Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Make calculating push actions faster #2177
Conversation
erikjohnston
added
maintenance
performance
labels
May 8, 2017
All checks have passed
Sytest Dendron (Commit)
— Build #2158 origin/erikj/faster_push_rules succeeded in 8 min 44 sec
Sytest Postgres (Commit)
— Build #2993 origin/erikj/faster_push_rules succeeded in 8 min 12 sec
Sytest SQLite (Commit)
— Build #3063 origin/erikj/faster_push_rules succeeded in 5 min 37 sec
erikjohnston
assigned
NegativeMjark
May 17, 2017
| + Returns: | ||
| + RulesForRoom | ||
| + """ | ||
| + return RulesForRoom(self.hs, room_id, self._get_rules_for_room.cache) |
NegativeMjark
May 18, 2017
•
Contributor
I think it's important that the RulesForRoom object is added to the self._get_rules_for_room.cache before any lookup methods are called on it, otherwise there would be a race in RulesForFroom.invalidate_all between adding the object to the cache and fetching it from the cache to invalidate it.
Might be worth chucking a comment in to that effect.
Some checks were not successful
continuous-integration/travis-ci/pr
— The Travis CI build could not complete due to an error
Sytest Dendron (Commit)
— Build #2162 origin/erikj/faster_push_rules succeeded in 7 min 27 sec
Sytest Postgres (Commit)
— Build #2997 origin/erikj/faster_push_rules succeeded in 8 min 48 sec
Sytest SQLite (Commit)
— Build #3067 origin/erikj/faster_push_rules succeeded in 5 min 16 sec
erikjohnston
merged commit 6e38118
into
develop
May 18, 2017
0 of 6 checks passed
Sytest Dendron (Commit)
Build #2162 origin/erikj/faster_push_rules in progress...
Details
Sytest Dendron (Merged PR)
Build started sha1 is merged.
Details
Sytest Postgres (Merged PR)
Build triggered. sha1 is merged.
Details
Sytest SQLite (Merged PR)
Build triggered. sha1 is merged.
Details
continuous-integration/travis-ci/pr
The Travis CI build is in progress
Details
continuous-integration/travis-ci/push
The Travis CI build is in progress
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
erikjohnston commentedMay 2, 2017
No description provided.