/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Cache check to see if device exists #2201

Merged
merged 4 commits into from May 8, 2017

Conversation

Reviewers

@richvdh richvdh

Assignees

@erikjohnston erikjohnston

Labels
maintenance performance
Projects
None yet
Milestone
No milestone
2 participants
@erikjohnston @richvdh
@erikjohnston
Owner

erikjohnston commented May 8, 2017

No description provided.

erikjohnston added some commits May 8, 2017

@erikjohnston
Cache check to see if device exists

All checks have passed

7 successful checks
@matrixbot
Sytest Dendron (Commit) — Build #2088 origin/erikj/store_device_cache succeeded in 7 min 44 sec
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #2923 origin/erikj/store_device_cache succeeded in 8 min 18 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #2992 origin/erikj/store_device_cache succeeded in 5 min 11 sec
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
738ccf6
@erikjohnston
Comment

All checks have passed

8 successful checks
@matrixbot
Sytest Dendron (Commit) — Build #2089 origin/erikj/store_device_cache succeeded in 9 min 8 sec
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #2924 origin/erikj/store_device_cache succeeded in 7 min 7 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #2993 origin/erikj/store_device_cache succeeded in 7 min 6 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
fc6d497

@erikjohnston erikjohnston assigned richvdh May 8, 2017

@erikjohnston erikjohnston added maintenance performance labels May 8, 2017

@richvdh

richvdh requested changes May 8, 2017
View changes

you need to flush the cache on delete

@richvdh richvdh assigned erikjohnston and unassigned richvdh May 8, 2017

@erikjohnston
Invalidate cache on device deletion

All checks have passed

8 successful checks
@matrixbot
Sytest Dendron (Commit) — Build #2091 origin/erikj/store_device_cache succeeded in 9 min 35 sec
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #2926 origin/erikj/store_device_cache succeeded in 8 min 13 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #2995 origin/erikj/store_device_cache succeeded in 5 min 11 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
94e6ad7

@erikjohnston erikjohnston assigned richvdh and unassigned erikjohnston May 8, 2017

@erikjohnston
Owner

erikjohnston commented May 8, 2017

Good spot. Though I'd imagine devices would get resurrected quite easily given they get created if they're ever referenced.
@richvdh

richvdh requested changes May 8, 2017
View changes

Though I'd imagine devices would get resurrected quite easily given they get created if they're ever referenced.

well, that's my point. They won't be (correctly) resurrected if you have a cache which says they exist when they've been deleted.

synapse/storage/devices.py
@@ -102,12 +115,14 @@ def delete_device(self, user_id, device_id):
Returns:
defer.Deferred
"""
- return self._simple_delete_one(
+ self._simple_delete_one(
@richvdh

richvdh May 8, 2017

Member

missing yield

synapse/storage/devices.py
@@ -117,13 +132,15 @@ def delete_devices(self, user_id, device_ids):
Returns:
defer.Deferred
"""
- return self._simple_delete_many(
+ self._simple_delete_many(
@richvdh

richvdh May 8, 2017

Member

missing yield

@erikjohnston
Add missing yields

All checks have passed

8 successful checks
@matrixbot
Sytest Dendron (Commit) — Build #2095 origin/erikj/store_device_cache succeeded in 7 min 21 sec
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #2930 origin/erikj/store_device_cache succeeded in 7 min 31 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #3000 origin/erikj/store_device_cache succeeded in 5 min 16 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
6a12998
@erikjohnston
Owner

erikjohnston commented May 8, 2017

well, that's my point. They won't be (correctly) resurrected if you have a cache which says they exist when they've been deleted.

Oh yes, i was just grumbling that its a bit of an odd API. Ignore me.

missing yield

Sigh, I clearly need more caffeine. Sorry.
@richvdh

richvdh approved these changes May 8, 2017
View changes

lgmt

@richvdh richvdh assigned erikjohnston and unassigned richvdh May 8, 2017

@erikjohnston erikjohnston merged commit d3c3026 into develop May 8, 2017
4 of 5 checks passed

4 of 5 checks passed

Sytest Postgres (Merged PR) Build started sha1 is merged.
Details
Sytest Dendron (Merged PR) Build finished.
Details
Sytest SQLite (Merged PR) Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

psaavedra added a commit to psaavedra/synapse that referenced this pull request May 19, 2017

@psaavedra
Merge tag 'v0.21.0' into v0.21.0_no_federate_by_default 
Changes in synapse v0.21.0 (2017-05-18)
=======================================

No changes since v0.21.0-rc3

Changes in synapse v0.21.0-rc3 (2017-05-17)
===========================================

Features:

* Add per user rate-limiting overrides (PR #2208)
* Add config option to limit maximum number of events requested by ``/sync``
  and ``/messages`` (PR #2221) Thanks to @psaavedra!

Changes:

* Various small performance fixes (PR #2201, #2202, #2224, #2226, #2227, #2228,
  #2229)
* Update username availability checker API (PR #2209, #2213)
* When purging, don't de-delta state groups we're about to delete (PR #2214)
* Documentation to check synapse version (PR #2215) Thanks to @hamber-dick!
* Add an index to event_search to speed up purge history API (PR #2218)

Bug fixes:

* Fix API to allow clients to upload one-time-keys with new sigs (PR #2206)

Changes in synapse v0.21.0-rc2 (2017-05-08)
===========================================

Changes:

* Always mark remotes as up if we receive a signed request from them (PR #2190)

Bug fixes:

* Fix bug where users got pushed for rooms they had muted (PR #2200)

Changes in synapse v0.21.0-rc1 (2017-05-08)
===========================================

Features:

* Add username availability checker API (PR #2183)
* Add read marker API (PR #2120)

Changes:

* Enable guest access for the 3pl/3pid APIs (PR #1986)
* Add setting to support TURN for guests (PR #2011)
* Various performance improvements (PR #2075, #2076, #2080, #2083, #2108,
  #2158, #2176, #2185)
* Make synctl a bit more user friendly (PR #2078, #2127) Thanks @APwhitehat!
* Replace HTTP replication with TCP replication (PR #2082, #2097, #2098,
  #2099, #2103, #2014, #2016, #2115, #2116, #2117)
* Support authenticated SMTP (PR #2102) Thanks @DanielDent!
* Add a counter metric for successfully-sent transactions (PR #2121)
* Propagate errors sensibly from proxied IS requests (PR #2147)
* Add more granular event send metrics (PR #2178)

Bug fixes:

* Fix nuke-room script to work with current schema (PR #1927) Thanks
  @zuckschwerdt!
* Fix db port script to not assume postgres tables are in the public schema
  (PR #2024) Thanks @jerrykan!
* Fix getting latest device IP for user with no devices (PR #2118)
* Fix rejection of invites to unreachable servers (PR #2145)
* Fix code for reporting old verify keys in synapse (PR #2156)
* Fix invite state to always include all events (PR #2163)
* Fix bug where synapse would always fetch state for any missing event (PR #2170)
* Fix a leak with timed out HTTP connections (PR #2180)
* Fix bug where we didn't time out HTTP requests to ASes  (PR #2192)

Docs:

* Clarify doc for SQLite to PostgreSQL port (PR #1961) Thanks @benhylau!
* Fix typo in synctl help (PR #2107) Thanks @HarHarLinks!
* ``web_client_location`` documentation fix (PR #2131) Thanks @matthewjwolff!
* Update README.rst with FreeBSD changes (PR #2132) Thanks @feld!
* Clarify setting up metrics (PR #2149) Thanks @encks!
badd30b

@erikjohnston erikjohnston deleted the erikj/store_device_cache branch Oct 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment