Allow clients to upload one-time-keys with new sigs #2206

Merged

richvdh merged 3 commits into develop from rav/one_time_key_upload_change_sig

May 10, 2017

Member

richvdh commented May 9, 2017

When a client retries a key upload, don't give an error if the signature
has changed (but the key is the same).

Fixes vector-im/riot-android#1208, hopefully.

Also some related tweaks - see individual commits.

richvdh added some commits May 9, 2017


      Allow clients to upload one-time-keys with new sigs

When a client retries a key upload, don't give an error if the signature has
changed (but the key is the same).

Fixes vector-im/riot-android#1208, hopefully.

a7e9d87


      Do some logging when one-time-keys get claimed

might help us figure out if vector-im/riot-web#3868
has happened.

de042b3


      Replace some instances of preserve_context_over_deferred

aedaba0

richvdh assigned erikjohnston May 9, 2017

erikjohnston approved these changes May 10, 2017

View changes

LGTM

ooi, why would the signatures change?

erikjohnston added the bug label May 10, 2017

Member

richvdh commented May 10, 2017

ooi, why would the signatures change?

vector-im/riot-android#1208 (comment)

Because the client stores the keys, but not the signatures.

richvdh merged commit `5331cd1` into develop May 10, 2017
7 checks passed

7 checks passed

Sytest Dendron (Commit) Build #2100 origin/rav/one_time_key_upload_change_sig succeeded in 9 min 23 sec

Details

Sytest Dendron (Merged PR) Build finished.

Details

Sytest Postgres (Commit) Build #2935 origin/rav/one_time_key_upload_change_sig succeeded in 6 min 12 sec

Details

Sytest Postgres (Merged PR) Build finished.

Details

Sytest SQLite (Commit) Build #3005 origin/rav/one_time_key_upload_change_sig succeeded in 5 min 18 sec

Details

Sytest SQLite (Merged PR) Build finished.

Details

continuous-integration/travis-ci/push The Travis CI build passed

Details

psaavedra added a commit to psaavedra/synapse that referenced this pull request May 19, 2017


      Merge tag 'v0.21.0' into v0.21.0_no_federate_by_default

Changes in synapse v0.21.0 (2017-05-18)
=======================================

No changes since v0.21.0-rc3

Changes in synapse v0.21.0-rc3 (2017-05-17)
===========================================

Features:

* Add per user rate-limiting overrides (PR #2208)
* Add config option to limit maximum number of events requested by ``/sync``
  and ``/messages`` (PR #2221) Thanks to @psaavedra!

Changes:

* Various small performance fixes (PR #2201, #2202, #2224, #2226, #2227, #2228,
  #2229)
* Update username availability checker API (PR #2209, #2213)
* When purging, don't de-delta state groups we're about to delete (PR #2214)
* Documentation to check synapse version (PR #2215) Thanks to @hamber-dick!
* Add an index to event_search to speed up purge history API (PR #2218)

Bug fixes:

* Fix API to allow clients to upload one-time-keys with new sigs (PR #2206)

Changes in synapse v0.21.0-rc2 (2017-05-08)
===========================================

Changes:

* Always mark remotes as up if we receive a signed request from them (PR #2190)

Bug fixes:

* Fix bug where users got pushed for rooms they had muted (PR #2200)

Changes in synapse v0.21.0-rc1 (2017-05-08)
===========================================

Features:

* Add username availability checker API (PR #2183)
* Add read marker API (PR #2120)

Changes:

* Enable guest access for the 3pl/3pid APIs (PR #1986)
* Add setting to support TURN for guests (PR #2011)
* Various performance improvements (PR #2075, #2076, #2080, #2083, #2108,
  #2158, #2176, #2185)
* Make synctl a bit more user friendly (PR #2078, #2127) Thanks @APwhitehat!
* Replace HTTP replication with TCP replication (PR #2082, #2097, #2098,
  #2099, #2103, #2014, #2016, #2115, #2116, #2117)
* Support authenticated SMTP (PR #2102) Thanks @DanielDent!
* Add a counter metric for successfully-sent transactions (PR #2121)
* Propagate errors sensibly from proxied IS requests (PR #2147)
* Add more granular event send metrics (PR #2178)

Bug fixes:

* Fix nuke-room script to work with current schema (PR #1927) Thanks
  @zuckschwerdt!
* Fix db port script to not assume postgres tables are in the public schema
  (PR #2024) Thanks @jerrykan!
* Fix getting latest device IP for user with no devices (PR #2118)
* Fix rejection of invites to unreachable servers (PR #2145)
* Fix code for reporting old verify keys in synapse (PR #2156)
* Fix invite state to always include all events (PR #2163)
* Fix bug where synapse would always fetch state for any missing event (PR #2170)
* Fix a leak with timed out HTTP connections (PR #2180)
* Fix bug where we didn't time out HTTP requests to ASes  (PR #2192)

Docs:

* Clarify doc for SQLite to PostgreSQL port (PR #1961) Thanks @benhylau!
* Fix typo in synctl help (PR #2107) Thanks @HarHarLinks!
* ``web_client_location`` documentation fix (PR #2131) Thanks @matthewjwolff!
* Update README.rst with FreeBSD changes (PR #2132) Thanks @feld!
* Clarify setting up metrics (PR #2149) Thanks @encks!

badd30b

richvdh deleted the rav/one_time_key_upload_change_sig branch Oct 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can't perform that action at this time.