Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Make get_state_groups_from_groups faster. #2230
Conversation
erikjohnston
assigned
NegativeMjark
and unassigned
NegativeMjark
May 17, 2017
erikjohnston
assigned
NegativeMjark
May 17, 2017
erikjohnston
added
maintenance
performance
labels
May 17, 2017
erikjohnston
merged commit d9e3a4b
into
develop
May 17, 2017
8 checks passed
Sytest Dendron (Commit)
Build #2153 origin/erikj/speed_up_get_state succeeded in 6 min 34 sec
Details
Sytest Dendron (Merged PR)
Build finished.
Details
Sytest Postgres (Commit)
Build #2988 origin/erikj/speed_up_get_state succeeded in 8 min 3 sec
Details
Sytest Postgres (Merged PR)
Build finished.
Details
Sytest SQLite (Commit)
Build #3058 origin/erikj/speed_up_get_state succeeded in 6 min 23 sec
Details
Sytest SQLite (Merged PR)
Build finished.
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
continuous-integration/travis-ci/push
The Travis CI build passed
Details
erikjohnston
deleted the
erikj/speed_up_get_state
branch
Oct 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
erikjohnston commentedMay 17, 2017
Most of the time was spent copying a dict to filter out sentinel values
that indicated that keys did not exist in the dict. The sentinel values
were added to ensure that we cached the non-existence of keys.
By updating DictionaryCache to keep track of which keys were known to
not exist itself we can remove a dictionary copy.