Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Speed up calculating push rules #2238
Conversation
Some checks were not successful
Sytest Postgres (Commit)
— Build #3020 origin/erikj/faster_push_rules succeeded in 6 min 13 sec
Sytest SQLite (Commit)
— Build #3090 origin/erikj/faster_push_rules succeeded in 5 min 20 sec
erikjohnston
assigned
NegativeMjark
May 19, 2017
| if key[0] != EventTypes.Member: | ||
| continue | ||
| + user_id = key[1] |
NegativeMjark
May 22, 2017
Contributor
If we are optimising it might be worth noting that a, b = key seems to be faster than a = key[0], b = key[1]
| @@ -200,6 +200,10 @@ def __init__(self, hs, room_id, rules_for_room_cache): | ||
| # not update the cache with it. | ||
| self.sequence = 0 | ||
| + # A cache of user_ids that we *know* aren't interesting, e.g. user_ids | ||
| + # owned by AS's, or remote users, etc. | ||
| + self.uninteresting_user_set = set() |
NegativeMjark
May 22, 2017
Contributor
Could we have a comment explaining why this cache doesn't need invalidation.
NegativeMjark
May 22, 2017
Contributor
Also might be worth explaining that "uninteresting" means "will never have push rules on this server"
|
Other than commenting on the |
erikjohnston
added some commits
May 22, 2017
All checks have passed
Sytest Postgres (Commit)
— Build #3021 origin/erikj/faster_push_rules succeeded in 5 min 26 sec
erikjohnston
merged commit ccd6241
into
develop
May 22, 2017
6 checks passed
Sytest Dendron (Merged PR)
Build finished.
Details
Sytest Postgres (Commit)
Build #3021 origin/erikj/faster_push_rules succeeded in 5 min 26 sec
Details
Sytest Postgres (Merged PR)
Build finished.
Details
Sytest SQLite (Merged PR)
Build finished.
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
continuous-integration/travis-ci/push
The Travis CI build passed
Details
erikjohnston
deleted the
erikj/faster_push_rules
branch
Oct 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
erikjohnston commentedMay 19, 2017
No description provided.