Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix removing of pushers when using workers #2267

Merged
merged 1 commit into from Jun 9, 2017

Conversation

Projects
None yet
2 participants
Owner

erikjohnston commented Jun 9, 2017

Fixes:

2017-06-07 13:42:02,380 - twisted - 131 - CRITICAL -  - Unhandled error in Deferred:
2017-06-07 13:42:02,380 - twisted - 131 - CRITICAL -  - 
Traceback (most recent call last):
  File "/home/matrix/.synapse/local/lib/python2.7/site-packages/twisted/internet/defer.py", line 1299, in _inlineCallbacks
    result = result.throwExceptionIntoGenerator(g)
  File "/home/matrix/.synapse/local/lib/python2.7/site-packages/twisted/python/failure.py", line 393, in throwExceptionIntoGenerator
    return g.throw(self.type, self.value, self.tb)
  File "synapse/util/metrics.py", line 58, in measured_func
  File "/home/matrix/.synapse/local/lib/python2.7/site-packages/twisted/internet/defer.py", line 1301, in _inlineCallbacks
    result = g.send(result)
  File "synapse/replication/tcp/resource.py", line 231, in on_remove_pusher
AttributeError: 'ReplicationStreamer' object has no attribute 'notifier'

@erikjohnston erikjohnston merged commit bfd6801 into develop Jun 9, 2017

8 of 9 checks passed

Sytest Dendron (Merged PR) Build finished.
Details
SynapseSytestPostgresPR Build #1946 detached succeeded in 7 min 56 sec
Details
Sytest Dendron (Commit) Build #2272 origin/erikj/missing_notifier succeeded in 8 min 45 sec
Details
Sytest Postgres (Commit) Build #3107 origin/erikj/missing_notifier succeeded in 7 min 20 sec
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Commit) Build #3182 origin/erikj/missing_notifier succeeded in 7 min 2 sec
Details
Sytest SQLite (Merged PR) Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@erikjohnston erikjohnston deleted the erikj/missing_notifier branch Oct 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment